From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: <git@jeffhostetler.com>, <git@vger.kernel.org>
Cc: "'Jeff King'" <peff@peff.net>,
"'SZEDER Gábor'" <szeder.dev@gmail.com>,
"'Johannes Schindelin via GitGitGadget'" <gitgitgadget@gmail.com>,
jeffhost@microsoft.com
Subject: [BUG] Unix Builds Requires Pthread Support (was [PATCH v4 00/12] Simple IPC Mechanism)
Date: Mon, 17 May 2021 13:46:46 -0400 [thread overview]
Message-ID: <009d01d74b44$9efe8a60$dcfb9f20$@nexbridge.com> (raw)
On Wed, 17 Feb 2021 21:48:36, Jeff Hostetler wrote:
>Here is V4 of my "Simple IPC" series. It addresses Gábor's comment WRT
>shutting down the server to make unit tests more predictable on CI servers.
>(https://lore.kernel.org/git/20210213093052.GJ1015009@szeder.dev)
I missed this at the time, but it appears that ipc-unix-socket.c forces a dependency on pthreads for Git under Unix-like platforms.
This is probably not a correct assumption (or likely intended), but causes git to no longer build on NonStop x86 and ia64 as of
2.32.0-rc0. I am not suggesting undoing this, but amending to make the change more sensitive to a lack of pthread support.
pthread_sigmask() showed up as an undefined external:
**** ERROR **** [1210]:
libgit.a(ipc-unix-socket.o): In function `thread_block_sigpipe':
ipc-unix-socket.o(.text+0xb87): unresolved reference to pthread_sigmask.
On NonStop, pthread_sigmask is defined in -lput or -lspt, which are not used in our build and would cause a bunch of other issues
if referenced. The build does define NO_PTHREADS.
A simple, but probably wrong fix to get the build to work is:
diff --git a/compat/simple-ipc/ipc-unix-socket.c b/compat/simple-ipc/ipc-unix-socket.c
index 38689b278d..07b2c407c1 100644
--- a/compat/simple-ipc/ipc-unix-socket.c
+++ b/compat/simple-ipc/ipc-unix-socket.c
@@ -535,7 +535,9 @@ static void thread_block_sigpipe(sigset_t *old_set)
sigaddset(&new_set, SIGPIPE);
sigemptyset(old_set);
+#ifndef NO_PTHREADS
pthread_sigmask(SIG_BLOCK, &new_set, old_set);
+#endif
}
But I suspect that this will not perform the desired action associated with blocking the signal, although since we are not in a
threading situation, that might be fine.
Thoughts?
Randall
-- Brief whoami:
NonStop developer since approximately 211288444200000000
UNIX developer since approximately 421664400
IBM developer since "I'm not talking about it"
-- In my real life, I talk too much.
next reply other threads:[~2021-05-17 17:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 17:46 Randall S. Becker [this message]
2021-05-18 8:23 ` [BUG] Unix Builds Requires Pthread Support (was [PATCH v4 00/12] Simple IPC Mechanism) Jeff King
2021-05-18 11:21 ` Jeff Hostetler
2021-05-18 12:11 ` Jeff King
2021-05-18 13:55 ` Jeff Hostetler
2021-05-18 13:37 ` Randall S. Becker
2021-05-18 13:59 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='009d01d74b44$9efe8a60$dcfb9f20$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jeffhost@microsoft.com \
--cc=peff@peff.net \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).