From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-2.7 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD shortcircuit=no autolearn=no autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 6F58E1F576 for ; Wed, 21 Feb 2018 07:02:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751534AbeBUHCj (ORCPT ); Wed, 21 Feb 2018 02:02:39 -0500 Received: from a7-11.smtp-out.eu-west-1.amazonses.com ([54.240.7.11]:51512 "EHLO a7-11.smtp-out.eu-west-1.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751369AbeBUHCi (ORCPT ); Wed, 21 Feb 2018 02:02:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=shh3fegwg5fppqsuzphvschd53n6ihuv; d=amazonses.com; t=1519196556; h=From:To:Message-ID:In-Reply-To:References:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=5btz4G2ovz2HstqPSNV6limMK0yOVtFo7yyYcpSC2ZQ=; b=D8z0G4hdTSMR1FKpUynytrTkBeL9mmLxFKnwNzR1i4KlIb0SL+tbPcBkRossd+ne J6MuohwSaVxdr9F7Mdlwz2+GKXijVJRB2uBJwDHQnPL6NA06px+r0o/BpVX+KMQ8Opi R82HpUU+XQWGlXo3E/y6NWdDigHKShSxQX1vgQbA= From: Olga Telezhnaya To: git@vger.kernel.org Message-ID: <01020161b72bce58-d3167109-3dd1-40fe-8ad9-727629cd918e-000000@eu-west-1.amazonses.com> In-Reply-To: <01020161b72bcdff-eb1350fb-12a2-4aaa-abb0-248bf481b2ab-000000@eu-west-1.amazonses.com> References: <01020161b72bcdff-eb1350fb-12a2-4aaa-abb0-248bf481b2ab-000000@eu-west-1.amazonses.com> Subject: [PATCH v2 2/2] ref-filter: get rid of goto MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Date: Wed, 21 Feb 2018 07:02:36 +0000 X-SES-Outgoing: 2018.02.21-54.240.7.11 Feedback-ID: 1.eu-west-1.YYPRFFOog89kHDDPKvTu4MK67j4wW0z7cAgZtFqQH58=:AmazonSES Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Get rid of goto command in ref-filter for better readability. Signed-off-by: Olga Telezhnaia Mentored-by: Christian Couder Mentored by: Jeff King --- ref-filter.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ref-filter.c b/ref-filter.c index 83ffd84affe52..35359818a1ebb 100644 --- a/ref-filter.c +++ b/ref-filter.c @@ -1494,11 +1494,11 @@ static void populate_value(struct ref_array_item *ref) for (i = 0; i < used_atom_cnt; i++) { struct atom_value *v = &ref->value[i]; if (v->s == NULL) - goto need_obj; + break; } - return; + if (i >= used_atom_cnt) + return; - need_obj: get_object(ref, &ref->objectname, 0, &obj); /* -- https://github.com/git/git/pull/460