From: <rsbecker@nexbridge.com>
To: "'Git Mailing List'" <git@vger.kernel.org>
Subject: [BUG] Non-portable Construct Introduced in diagnose.c (dirent) at v2.38.0-rc0
Date: Fri, 16 Sep 2022 19:04:49 -0400 [thread overview]
Message-ID: <011001d8ca20$bc4d81f0$34e885d0$@nexbridge.com> (raw)
The dirent d_type field is not available on every system. This was
introduced at 2.38.0-rc0 in diagnose.c
diagnose.c, line 79: error(1565): struct "dirent" has no field "d_type"
e->d_type == DT_DIR && strlen(e->d_name) == 2 &&
(3 more issues in diagnose exist of this form).
The code should use the NO_D_TYPE_IN_DIRENT knob to detect whether this is
an existing field as defined in cache.h.
This change breaks the build on NonStop systems (at least). I'm sorry I
missed this during review.
Randall
--
Brief whoami: NonStop&UNIX developer since approximately
UNIX(421664400)
NonStop(211288444200000000)
-- In real life, I talk too much.
next reply other threads:[~2022-09-16 23:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 23:04 rsbecker [this message]
2022-09-16 23:11 ` [BUG] Non-portable Construct Introduced in diagnose.c (dirent) at v2.38.0-rc0 Victoria Dye
2022-09-16 23:14 ` rsbecker
2022-09-17 0:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='011001d8ca20$bc4d81f0$34e885d0$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).