From: Diomidis Spinellis <dds@aueb.gr>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Git List <git@vger.kernel.org>,
Diomidis Spinellis via GitGitGadget <gitgitgadget@gmail.com>
Subject: Re: [PATCH] grep: fix multibyte regex handling under macOS
Date: Wed, 24 Aug 2022 08:13:55 +0300 [thread overview]
Message-ID: <05275758-2b69-a4bd-30ca-4d48cbfe39f5@aueb.gr> (raw)
In-Reply-To: <CAPig+cSf+Gi4cHQLcTenxH=RzBxxqCApKhFTkCUMAS=0fYXZDA@mail.gmail.com>
On 23-Aug-22 23:40, Eric Sunshine wrote:
> On Tue, Aug 23, 2022 at 4:04 PM Diomidis Spinellis via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>> diff --git a/t/t7818-grep-multibyte.sh b/t/t7818-grep-multibyte.sh
>> +# Multibyte regex search is only supported with a native regex library
>> +# that supports them.
>> +# (The included library is compiled with NO_MBSUPPORT) and only if it
>> +test -z "$NO_REGEX" &&
>
> The comment above seems incomplete (i.e. "and only if it...").
Thank you for pointing this out. I posted an update that fixes this.
Diomidis
next prev parent reply other threads:[~2022-08-24 5:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 19:08 [PATCH] grep: fix multibyte regex handling under macOS Diomidis Spinellis via GitGitGadget
2022-08-23 20:40 ` Eric Sunshine
2022-08-24 5:13 ` Diomidis Spinellis [this message]
2022-08-23 21:26 ` [PATCH v2] " Diomidis Spinellis via GitGitGadget
2022-08-24 18:56 ` Junio C Hamano
2022-08-25 8:23 ` Diomidis Spinellis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05275758-2b69-a4bd-30ca-4d48cbfe39f5@aueb.gr \
--to=dds@aueb.gr \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).