From: Andrzej Hunt <andrzej@ahunt.org>
To: Carlo Arenas <carenas@gmail.com>,
Andrzej Hunt via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/2] Squash leaks in t0000
Date: Sun, 19 Sep 2021 17:38:43 +0200 [thread overview]
Message-ID: <05754f9c-cd58-30f5-e2d3-58b9221d2770@ahunt.org> (raw)
In-Reply-To: <CAPUEspjjBAr07VB7XqGFVXDcKWkkX4OUTCxUf+VJaEAX8KTAyw@mail.gmail.com>
On 18/09/2021 19:28, Carlo Arenas wrote:
>
>> Here's a series that I've sat on for a while, which adds some UNLEAK's to
>> "fix" this situation - see the individual patches for a justification of why
>> an UNLEAK seems appropriate.
>
> While I see that UNLEAK in this specific case, might be an ok "fix", I
> have to admit that not finding a repo_clear_revisions() (or equivalent
> function) that could be used to clear revs seems like a problem worth
> fixing as well for the future.
>
> Will reply with my WIP so we can see if it could work either as an
> alternative to this, or at least lay some foundations so that a long
> running process that needs to use a `struct revision` or some of this
> logic can in the future without having to deal with leaks.
Great - in this case I think it's best to ignore my patches since
actually fixing the leaks is obviously a better solution :) !
ATB,
Andrzej
next prev parent reply other threads:[~2021-09-19 15:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 13:49 [PATCH 0/2] Squash leaks in t0000 Andrzej Hunt via GitGitGadget
2021-09-18 13:49 ` [PATCH 1/2] log: UNLEAK rev to silence a large number of leaks Andrzej Hunt via GitGitGadget
2021-09-18 20:06 ` Carlo Marcelo Arenas Belón
2021-09-19 15:51 ` Andrzej Hunt
2021-09-19 16:13 ` Ævar Arnfjörð Bjarmason
2021-09-19 21:34 ` Carlo Marcelo Arenas Belón
2021-09-20 6:06 ` Eric Sunshine
2021-09-20 21:39 ` Carlo Marcelo Arenas Belón
2021-09-21 3:09 ` Jeff King
2021-09-18 13:49 ` [PATCH 2/2] log: UNLEAK original pending objects Andrzej Hunt via GitGitGadget
2021-09-18 17:28 ` [PATCH 0/2] Squash leaks in t0000 Carlo Arenas
2021-09-19 15:38 ` Andrzej Hunt [this message]
2021-09-19 10:58 ` Ævar Arnfjörð Bjarmason
2021-09-20 17:55 ` Junio C Hamano
2021-09-21 23:01 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05754f9c-cd58-30f5-e2d3-58b9221d2770@ahunt.org \
--to=andrzej@ahunt.org \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).