git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Jeff King <peff@peff.net>, Bagas Sanjaya <bagasdotme@gmail.com>
Cc: git@vger.kernel.org, dyroneteng@gmail.com, levraiphilippeblain@gmail.com
Subject: Re: [PATCH] clone: caveat note on converting partial clone
Date: Tue, 1 Jun 2021 06:46:17 -0400	[thread overview]
Message-ID: <08cfd066-dda5-40a7-8467-5e621e0ea619@gmail.com> (raw)
In-Reply-To: <YLQH7i5IPSdBnDko@coredump.intra.peff.net>

On 5/30/21 5:47 PM, Jeff King wrote:
> On Sat, May 29, 2021 at 07:07:31PM +0700, Bagas Sanjaya wrote:
> 
>> Currently partial clones can't be converted into full clones, because
>> there is an issue where the remote can't send all missing objects
>> required.
>>
>> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
>> ---
>>  This patch is based on "clone: document partial clone section" by Teng
>>  Long [1].
>>
>>  [1]:
>> https://lore.kernel.org/git/pull.745.v5.git.git.1614695133486.gitgitgadget@gmail.com/
> 
> Wouldn't:
> 
>   git -c fetch.negotiationAlgorithm=noop fetch ...
> 
> work?
> 
> IMHO that is not ideal, and I would like to see it work even when we
> provide "have" lines to the server. But if we are going to tell users
> something in the documentation, pointing them to this technique is
> probably much more helpful than saying "it can't be done".

Any workaround is better than none.

At minimum, I would expect a summary of the discussion instead of
a pointer to a mailing list thread.

Thanks,
-Stolee

      reply	other threads:[~2021-06-01 10:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-29 12:07 [PATCH] clone: caveat note on converting partial clone Bagas Sanjaya
2021-05-30 21:47 ` Jeff King
2021-06-01 10:46   ` Derrick Stolee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08cfd066-dda5-40a7-8467-5e621e0ea619@gmail.com \
    --to=stolee@gmail.com \
    --cc=bagasdotme@gmail.com \
    --cc=dyroneteng@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=levraiphilippeblain@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).