From: Phillip Wood <phillip.wood123@gmail.com>
To: John Cai via GitGitGadget <gitgitgadget@gmail.com>, git@vger.kernel.org
Cc: me@ttaylorr.com, avarab@gmail.com, e@80x24.org,
bagasdotme@gmail.com, gitster@pobox.com,
Eric Sunshine <sunshine@sunshineco.com>,
Jonathan Tan <jonathantanmy@google.com>,
Christian Couder <christian.couder@gmail.com>,
John Cai <johncai86@gmail.com>
Subject: Re: [PATCH v9 4/4] cat-file: add --batch-command mode
Date: Fri, 18 Feb 2022 11:26:10 +0000 [thread overview]
Message-ID: <095278d4-217b-7d97-5364-9cd491b34ed0@gmail.com> (raw)
In-Reply-To: <dbe194f8a8592dd67d6ba3a11cb7b1c81b789cec.1645045157.git.gitgitgadget@gmail.com>
Hi John
This is looking good. I think the only thing that is missing (and which
I should have realized earlier) is that there are no tests for valid or
invalid format arguments to --batch-command. I haven't checked but there
must be some other tests in the t1006 that we can piggy back on to add
that. I've left some stylistic comments below but I don't fell strongly
about them apart from the README comment so please don't feel obliged to
act on them, it's looking pretty good as is.
Best Wishes
Phillip
On 16/02/2022 20:59, John Cai via GitGitGadget wrote:
> From: John Cai <johncai86@gmail.com>
>
> Add a new flag --batch-command that accepts commands and arguments
> from stdin, similar to git-update-ref --stdin.
>
> At GitLab, we use a pair of long running cat-file processes when
> accessing object content. One for iterating over object metadata with
> --batch-check, and the other to grab object contents with --batch.
>
> However, if we had --batch-command, we wouldn't need to keep both
> processes around, and instead just have one --batch-command process
> where we can flip between getting object info, and getting object
> contents. Since we have a pair of cat-file processes per repository,
> this means we can get rid of roughly half of long lived git cat-file
> processes. Given there are many repositories being accessed at any given
> time, this can lead to huge savings.
>
> git cat-file --batch-command
>
> will enter an interactive command mode whereby the user can enter in
> commands and their arguments that get queued in memory:
>
> <command1> [arg1] [arg2] LF
> <command2> [arg1] [arg2] LF
>
> When --buffer mode is used, commands will be queued in memory until a
> flush command is issued that execute them:
>
> flush LF
>
> The reason for a flush command is that when a consumer process (A)
> talks to a git cat-file process (B) and interactively writes to and
> reads from it in --buffer mode, (A) needs to be able to control when
> the buffer is flushed to stdout.
>
> Currently, from (A)'s perspective, the only way is to either
>
> 1. kill (B)'s process
> 2. send an invalid object to stdin.
>
> 1. is not ideal from a performance perspective as it will require
> spawning a new cat-file process each time, and 2. is hacky and not a
> good long term solution.
>
> With this mechanism of queueing up commands and letting (A) issue a
> flush command, process (A) can control when the buffer is flushed and
> can guarantee it will receive all of the output when in --buffer mode.
> --batch-command also will not allow (B) to flush to stdout until a flush
> is received.
>
> This patch adds the basic structure for adding command which can be
> extended in the future to add more commands. It also adds the following
> two commands (on top of the flush command):
>
> contents <object> LF
> info <object> LF
>
> The contents command takes an <object> argument and prints out the object
> contents.
>
> The info command takes an <object> argument and prints out the object
> metadata.
>
> These can be used in the following way with --buffer:
>
> info <object> LF
> contents <object> LF
> contents <object> LF
> info <object> LF
> flush LF
> info <object> LF
> flush LF
>
> When used without --buffer:
>
> info <object> LF
> contents <object> LF
> contents <object> LF
> info <object> LF
> info <object> LF
>
> Helped-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> Signed-off-by: John Cai <johncai86@gmail.com>
> ---
> Documentation/git-cat-file.txt | 42 +++++++++-
> builtin/cat-file.c | 147 ++++++++++++++++++++++++++++++++-
> t/README | 3 +
> t/t1006-cat-file.sh | 107 +++++++++++++++++++++++-
> 4 files changed, 293 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/git-cat-file.txt b/Documentation/git-cat-file.txt
> index bef76f4dd06..70c5b4f12d1 100644
> --- a/Documentation/git-cat-file.txt
> +++ b/Documentation/git-cat-file.txt
> @@ -96,6 +96,33 @@ OPTIONS
> need to specify the path, separated by whitespace. See the
> section `BATCH OUTPUT` below for details.
>
> +--batch-command::
> +--batch-command=<format>::
> + Enter a command mode that reads commands and arguments from stdin. May
> + only be combined with `--buffer`, `--textconv` or `--filters`. In the
> + case of `--textconv` or `--filters`, the input lines also need to specify
> + the path, separated by whitespace. See the section `BATCH OUTPUT` below
> + for details.
> ++
> +`--batch-command` recognizes the following commands:
> ++
> +--
> +contents <object>::
> + Print object contents for object reference `<object>`. This corresponds to
> + the output of `--batch`.
> +
> +info <object>::
> + Print object info for object reference `<object>`. This corresponds to the
> + output of `--batch-check`.
> +
> +flush::
> + Used with `--buffer` to execute all preceding commands that were issued
> + since the beginning or since the last flush was issued. When `--buffer`
> + is used, no output will come until a `flush` is issued. When `--buffer`
> + is not used, commands are flushed each time without issuing `flush`.
> +--
> ++
> +
> --batch-all-objects::
> Instead of reading a list of objects on stdin, perform the
> requested batch operation on all objects in the repository and
> @@ -110,7 +137,7 @@ OPTIONS
> that a process can interactively read and write from
> `cat-file`. With this option, the output uses normal stdio
> buffering; this is much more efficient when invoking
> - `--batch-check` on a large number of objects.
> + `--batch-check` or `--batch-command` on a large number of objects.
>
> --unordered::
> When `--batch-all-objects` is in use, visit objects in an
> @@ -202,6 +229,13 @@ from stdin, one per line, and print information about them. By default,
> the whole line is considered as an object, as if it were fed to
> linkgit:git-rev-parse[1].
>
> +When `--batch-command` is given, `cat-file` will read commands from stdin,
> +one per line, and print information based on the command given. With
> +`--batch-command`, the `info` command followed by an object will print
> +information about the object the same way `--batch-check` would, and the
> +`contents` command followed by an object prints contents in the same way
> +`--batch` would.
> +
> You can specify the information shown for each object by using a custom
> `<format>`. The `<format>` is copied literally to stdout for each
> object, with placeholders of the form `%(atom)` expanded, followed by a
> @@ -237,9 +271,9 @@ newline. The available atoms are:
> If no format is specified, the default format is `%(objectname)
> %(objecttype) %(objectsize)`.
>
> -If `--batch` is specified, the object information is followed by the
> -object contents (consisting of `%(objectsize)` bytes), followed by a
> -newline.
> +If `--batch` is specified, or if `--batch-command` is used with the `contents`
> +command, the object information is followed by the object contents (consisting
> +of `%(objectsize)` bytes), followed by a newline.
>
> For example, `--batch` without a custom format would produce:
>
> diff --git a/builtin/cat-file.c b/builtin/cat-file.c
> index 5e38af82af1..3dc960e9f85 100644
> --- a/builtin/cat-file.c
> +++ b/builtin/cat-file.c
> @@ -20,6 +20,7 @@
> enum batch_mode {
> BATCH_MODE_CONTENTS,
> BATCH_MODE_INFO,
> + BATCH_MODE_QUEUE_AND_DISPATCH,
> };
>
> struct batch_options {
> @@ -513,6 +514,138 @@ static int batch_unordered_packed(const struct object_id *oid,
> data);
> }
>
> +typedef void (*parse_cmd_fn_t)(struct batch_options *, const char *,
> + struct strbuf *, struct expand_data *);
> +
> +struct queued_cmd {
> + parse_cmd_fn_t fn;
> + char *line;
> +};
> +
> +static void parse_cmd_contents(struct batch_options *opt,
> + const char *line,
> + struct strbuf *output,
> + struct expand_data *data)
> +{
> + opt->batch_mode = BATCH_MODE_CONTENTS;
> + batch_one_object(line, output, opt, data);
> +}
> +
> +static void parse_cmd_info(struct batch_options *opt,
> + const char *line,
> + struct strbuf *output,
> + struct expand_data *data)
> +{
> + opt->batch_mode = BATCH_MODE_INFO;
> + batch_one_object(line, output, opt, data);
> +}
> +
> +static void dispatch_calls(struct batch_options *opt,
> + struct strbuf *output,
> + struct expand_data *data,
> + struct queued_cmd *cmd,
> + int nr)
> +{
> + int i;
> +
> + if (!opt->buffer_output)
> + die(_("flush is only for --buffer mode"));
> +
> + for (i = 0; i < nr; i++)
> + cmd[i].fn(opt, cmd[i].line, output, data);
> +
> + fflush(stdout);
> +}
> +
> +static void free_cmds(struct queued_cmd *cmd, int nr)
> +{
> + int i;
> +
> + for (i = 0; i < nr; i++)
> + FREE_AND_NULL(cmd[i].line);
> +}
> +
> +
> +static const struct parse_cmd {
> + const char *name;
> + parse_cmd_fn_t fn;
> + unsigned takes_args;
> +} commands[] = {
> + { "contents", parse_cmd_contents, 1},
> + { "info", parse_cmd_info, 1},
> + { "flush", NULL, 0},
> +};
> +
> +static void batch_objects_command(struct batch_options *opt,
> + struct strbuf *output,
> + struct expand_data *data)
> +{
> + struct strbuf input = STRBUF_INIT;
> + struct queued_cmd *queued_cmd = NULL;
> + size_t alloc = 0, nr = 0;
> +
> + while (!strbuf_getline(&input, stdin)) {
> + int i;
> + const struct parse_cmd *cmd = NULL;
> + const char *p = NULL, *cmd_end;
> + struct queued_cmd call = {0};
> +
> + if (!input.len)
> + die(_("empty command in input"));
> + if (isspace(*input.buf))
> + die(_("whitespace before command: '%s'"), input.buf);
> +
> + for (i = 0; i < ARRAY_SIZE(commands); i++) {
> + if (!skip_prefix(input.buf, commands[i].name, &cmd_end))
> + continue;
> +
> + cmd = &commands[i];
> + if (cmd->takes_args) {
> + if (*cmd_end != ' ')
> + die(_("%s requires arguments"),
> + commands[i].name);
> +
> + p = cmd_end + 1;
> + } else if (*cmd_end) {
> + die(_("%s takes no arguments"),
> + commands[i].name);
> + }
> +
> + break;
> + }
> +
> + if (!cmd)
> + die(_("unknown command: '%s'"), input.buf);
> +
> + if (!strcmp(cmd->name, "flush")) {
> + dispatch_calls(opt, output, data, queued_cmd, nr);
> + free_cmds(queued_cmd, nr);
> + nr = 0;
It'd be nice if free_cmds() zeroed nr for us rather than having to
remember to do it separately as the two are intimately linked.
> + continue;
> + }
> +
> + if (!opt->buffer_output) {
> + cmd->fn(opt, p, output, data);
> + continue;
> + }
> +
> + ALLOC_GROW(queued_cmd, nr + 1, alloc);
> + call.fn = cmd->fn;
> + call.line = xstrdup_or_null(p);
> + queued_cmd[nr++] = call;
I found this a bit confusing to follow with all the "continue"s for me
it would be easier to follow if this was written as
if (!strcmp(cmd->name, "flush") {
...
} else if (!opt->buffer_output) {
...
} else {
ALLOC_GROW ...
}
> + }
> +
> + if (opt->buffer_output &&
> + nr &&
> + !git_env_bool("GIT_TEST_CAT_FILE_NO_FLUSH_ON_EXIT", 0)) {
> + dispatch_calls(opt, output, data, queued_cmd, nr);
> + free_cmds(queued_cmd, nr);
> + }
> +
> + free(queued_cmd);
> + strbuf_release(&input);
> +}
> +
> static int batch_objects(struct batch_options *opt)
> {
> struct strbuf input = STRBUF_INIT;
> @@ -595,6 +728,11 @@ static int batch_objects(struct batch_options *opt)
> save_warning = warn_on_object_refname_ambiguity;
> warn_on_object_refname_ambiguity = 0;
>
> + if (opt->batch_mode == BATCH_MODE_QUEUE_AND_DISPATCH) {
> + batch_objects_command(opt, &output, &data);
> + goto cleanup;
> + }
> +
> while (strbuf_getline(&input, stdin) != EOF) {
> if (data.split_on_whitespace) {
> /*
> @@ -613,6 +751,7 @@ static int batch_objects(struct batch_options *opt)
> batch_one_object(input.buf, &output, opt, &data);
> }
>
> + cleanup:
> strbuf_release(&input);
> strbuf_release(&output);
> warn_on_object_refname_ambiguity = save_warning;
> @@ -645,6 +784,8 @@ static int batch_option_callback(const struct option *opt,
> bo->batch_mode = BATCH_MODE_CONTENTS;
> else if (!strcmp(opt->long_name, "batch-check"))
> bo->batch_mode = BATCH_MODE_INFO;
> + else if (!strcmp(opt->long_name, "batch-command"))
> + bo->batch_mode = BATCH_MODE_QUEUE_AND_DISPATCH;
> else
> BUG("%s given to batch-option-callback", opt->long_name);
>
> @@ -666,7 +807,7 @@ int cmd_cat_file(int argc, const char **argv, const char *prefix)
> N_("git cat-file <type> <object>"),
> N_("git cat-file (-e | -p) <object>"),
> N_("git cat-file (-t | -s) [--allow-unknown-type] <object>"),
> - N_("git cat-file (--batch | --batch-check) [--batch-all-objects]\n"
> + N_("git cat-file (--batch | --batch-check | --batch-command) [--batch-all-objects]\n"
> " [--buffer] [--follow-symlinks] [--unordered]\n"
> " [--textconv | --filters]"),
> N_("git cat-file (--textconv | --filters)\n"
> @@ -695,6 +836,10 @@ int cmd_cat_file(int argc, const char **argv, const char *prefix)
> N_("like --batch, but don't emit <contents>"),
> PARSE_OPT_OPTARG | PARSE_OPT_NONEG,
> batch_option_callback),
> + OPT_CALLBACK_F(0, "batch-command", &batch, N_("format"),
> + N_("read commands from stdin"),
> + PARSE_OPT_OPTARG | PARSE_OPT_NONEG,
> + batch_option_callback),
> OPT_CMDMODE(0, "batch-all-objects", &opt,
> N_("with --batch[-check]: ignores stdin, batches all known objects"), 'b'),
> /* Batch-specific options */
> diff --git a/t/README b/t/README
> index f48e0542cdc..bcd813b0c59 100644
> --- a/t/README
> +++ b/t/README
> @@ -472,6 +472,9 @@ a test and then fails then the whole test run will abort. This can help to make
> sure the expected tests are executed and not silently skipped when their
> dependency breaks or is simply not present in a new environment.
>
> +GIT_TEST_CAT_FILE_NO_FLUSH_ON_EXIT=<boolean>, when true will prevent cat-file
> +--batch-command from flushing to output on exit.
I don't think you need to document this here. Looking at the other
variables this is a list of things one can set to change the behavior of
the tests when they are run. GIT_TEST_CAT_FILE_NO_FLUSH is not in that
category - we don't want anyone setting it when they run the tests, it's
just an implementation detail.
> +
> Naming Tests
> ------------
>
> diff --git a/t/t1006-cat-file.sh b/t/t1006-cat-file.sh
> index 2d52851dadc..74f0e36b69e 100755
> --- a/t/t1006-cat-file.sh
> +++ b/t/t1006-cat-file.sh
> @@ -182,6 +182,24 @@ $content"
> test_cmp expect actual
> '
>
> + for opt in --buffer --no-buffer
> + do
> + test -z "$content" ||
> + test_expect_success "--batch-command $opt output of $type content is correct" '
> + maybe_remove_timestamp "$batch_output" $no_ts >expect &&
> + maybe_remove_timestamp "$(test_write_lines "contents $sha1" \
> + | git cat-file --batch-command $opt)" $no_ts >actual &&
> + test_cmp expect actual
> + '
> +
> + test_expect_success "--batch-command $opt output of $type info is correct" '
> + echo "$sha1 $type $size" >expect &&
> + test_write_lines "info $sha1" \
> + | git cat-file --batch-command $opt >actual &&
> + test_cmp expect actual
> + '
> + done
> +
> test_expect_success "custom --batch-check format" '
> echo "$type $sha1" >expect &&
> echo $sha1 | git cat-file --batch-check="%(objecttype) %(objectname)" >actual &&
> @@ -229,6 +247,22 @@ test_expect_success "setup" '
>
> run_tests 'blob' $hello_sha1 $hello_size "$hello_content" "$hello_content"
>
> +test_expect_success '--batch-command --buffer with flush for blob info' '
> + echo "$hello_sha1 blob $hello_size" >expect &&
> + test_write_lines "info $hello_sha1" "flush" | \
You don't need a '\' after a '|', however it might be better to use the
style from the tests above where the '|' is on the beginning of the next
line.
> + GIT_TEST_CAT_FILE_NO_FLUSH_ON_EXIT=1 \
> + git cat-file --batch-command --buffer >actual &&
> + test_cmp expect actual
> +'
> +
> +test_expect_success '--batch-command --buffer without flush for blob info' '
> + touch output &&
> + test_write_lines "info $hello_sha1" | \
> + GIT_TEST_CAT_FILE_NO_FLUSH_ON_EXIT=1 \
> + git cat-file --batch-command --buffer >>output &&
> + test_must_be_empty output
> +'
> +
> test_expect_success '--batch-check without %(rest) considers whole line' '
> echo "$hello_sha1 blob $hello_size" >expect &&
> git update-index --add --cacheinfo 100644 $hello_sha1 "white space" &&
> @@ -272,7 +306,7 @@ test_expect_success \
> "Reach a blob from a tag pointing to it" \
> "test '$hello_content' = \"\$(git cat-file blob $tag_sha1)\""
>
> -for batch in batch batch-check
> +for batch in batch batch-check batch-command
> do
> for opt in t s e p
> do
> @@ -378,6 +412,42 @@ test_expect_success "--batch-check with multiple sha1s gives correct format" '
> "$(echo_without_newline "$batch_check_input" | git cat-file --batch-check)"
> '
>
> +test_expect_success '--batch-command with multiple info calls gives correct format' '
> + cat >expect <<-EOF &&
> + $hello_sha1 blob $hello_size
> + $tree_sha1 tree $tree_size
> + $commit_sha1 commit $commit_size
> + $tag_sha1 tag $tag_size
> + deadbeef missing
> + EOF
> +
> + test_write_lines "info $hello_sha1"\
> + "info $tree_sha1"\
> + "info $commit_sha1"\
> + "info $tag_sha1"\
> + "info deadbeef" | git cat-file --batch-command --buffer >actual &&
This is quite noisy with all the " and \, using a here document instead
would match our usual style.
> + test_cmp expect actual
> +'
> +
> +test_expect_success '--batch-command with multiple command calls gives correct format' '
> + remove_timestamp >expect <<-EOF &&
> + $hello_sha1 blob $hello_size
> + $hello_content
> + $commit_sha1 commit $commit_size
> + $commit_content
> + $tag_sha1 tag $tag_size
> + $tag_content
> + deadbeef missing
> + EOF
> +
> + test_write_lines "contents $hello_sha1"\
> + "contents $commit_sha1"\
> + "contents $tag_sha1"\
> + "contents deadbeef"\
> + "flush" | git cat-file --batch-command --buffer | remove_timestamp >actual &&
This loses the exit code of the command we're trying to test, it would
be better to have
git cat-file ... >actual-raw &&
remove_timestamp <actual-raw >actual
> + test_cmp expect actual
> +'
> +
> test_expect_success 'setup blobs which are likely to delta' '
> test-tool genrandom foo 10240 >foo &&
> { cat foo && echo plus; } >foo-plus &&
> @@ -968,5 +1038,40 @@ test_expect_success 'cat-file --batch-all-objects --batch-check ignores replace'
> echo "$orig commit $orig_size" >expect &&
> test_cmp expect actual
> '
> +test_expect_success 'batch-command empty command' '
> + echo "" >cmd &&
> + test_expect_code 128 git cat-file --batch-command <cmd 2>err &&
> + grep "^fatal:.*empty command in input.*" err
> +'
> +
> +test_expect_success 'batch-command whitespace before command' '
> + echo " info deadbeef" >cmd &&
> + test_expect_code 128 git cat-file --batch-command <cmd 2>err &&
> + grep "^fatal:.*whitespace before command.*" err
> +'
> +
> +test_expect_success 'batch-command unknown command' '
> + echo unknown_command >cmd &&
> + test_expect_code 128 git cat-file --batch-command <cmd 2>err &&
> + grep "^fatal:.*unknown command.*" err
> +'
> +
> +test_expect_success 'batch-command missing arguments' '
> + echo "info" >cmd &&
> + test_expect_code 128 git cat-file --batch-command <cmd 2>err &&
> + grep "^fatal:.*info requires arguments.*" err
> +'
> +
> +test_expect_success 'batch-command flush with arguments' '
> + echo "flush arg" >cmd &&
> + test_expect_code 128 git cat-file --batch-command --buffer <cmd 2>err &&
> + grep "^fatal:.*flush takes no arguments.*" err
> +'
> +
> +test_expect_success 'batch-command flush without --buffer' '
> + echo "flush" >cmd &&
> + test_expect_code 128 git cat-file --batch-command <cmd 2>err &&
> + grep "^fatal:.*flush is only for --buffer mode.*" err
> +'
>
> test_done
next prev parent reply other threads:[~2022-02-18 11:26 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 19:08 [PATCH 0/2] Add cat-file --batch-command flag John Cai via GitGitGadget
2022-02-03 19:08 ` [PATCH 1/2] cat-file.c: rename cmdmode to mode John Cai via GitGitGadget
2022-02-03 19:28 ` Junio C Hamano
2022-02-04 12:10 ` Ævar Arnfjörð Bjarmason
2022-02-03 19:08 ` [PATCH 2/2] catfile.c: add --batch-command mode John Cai via GitGitGadget
2022-02-03 19:57 ` Junio C Hamano
2022-02-04 4:11 ` John Cai
2022-02-04 16:46 ` Phillip Wood
2022-02-04 6:45 ` Eric Sunshine
2022-02-04 21:41 ` John Cai
2022-02-05 6:52 ` Eric Sunshine
2022-02-04 12:11 ` Ævar Arnfjörð Bjarmason
2022-02-04 16:51 ` Phillip Wood
2022-02-07 16:33 ` [PATCH v2 0/2] Add cat-file --batch-command flag John Cai via GitGitGadget
2022-02-07 16:33 ` [PATCH v2 1/2] cat-file: rename cmdmode to transform_mode John Cai via GitGitGadget
2022-02-07 23:58 ` Junio C Hamano
2022-02-07 16:33 ` [PATCH v2 2/2] cat-file: add --batch-command mode John Cai via GitGitGadget
2022-02-07 23:34 ` Jonathan Tan
2022-02-08 11:00 ` Phillip Wood
2022-02-08 17:56 ` Jonathan Tan
2022-02-08 18:09 ` Junio C Hamano
2022-02-09 0:11 ` Jonathan Tan
2022-02-08 0:49 ` Junio C Hamano
2022-02-08 11:06 ` Phillip Wood
2022-02-08 20:58 ` [PATCH v3 0/3] Add cat-file --batch-command flag John Cai via GitGitGadget
2022-02-08 20:58 ` [PATCH v3 1/3] cat-file: rename cmdmode to transform_mode John Cai via GitGitGadget
2022-02-08 20:58 ` [PATCH v3 2/3] cat-file: introduce batch_command enum to replace print_contents John Cai via GitGitGadget
2022-02-08 23:43 ` Junio C Hamano
2022-02-08 20:58 ` [PATCH v3 3/3] cat-file: add --batch-command mode John Cai via GitGitGadget
2022-02-08 23:59 ` Junio C Hamano
2022-02-09 21:40 ` [PATCH v3 0/3] Add cat-file --batch-command flag Junio C Hamano
2022-02-09 22:22 ` John Cai
2022-02-09 23:10 ` John Cai
2022-02-10 4:01 ` [PATCH v4 " John Cai via GitGitGadget
2022-02-10 4:01 ` [PATCH v4 1/3] cat-file: rename cmdmode to transform_mode John Cai via GitGitGadget
2022-02-10 4:01 ` [PATCH v4 2/3] cat-file: introduce batch_mode enum to replace print_contents John Cai via GitGitGadget
2022-02-10 10:10 ` Christian Couder
2022-02-10 4:01 ` [PATCH v4 3/3] cat-file: add --batch-command mode John Cai via GitGitGadget
2022-02-10 10:57 ` Phillip Wood
2022-02-10 17:05 ` Junio C Hamano
2022-02-11 17:45 ` John Cai
2022-02-11 20:07 ` Junio C Hamano
2022-02-11 21:30 ` John Cai
2022-02-10 18:55 ` John Cai
2022-02-10 22:46 ` Eric Sunshine
2022-02-10 20:30 ` [PATCH v4 0/3] Add cat-file --batch-command flag Junio C Hamano
2022-02-11 20:01 ` [PATCH v5 " John Cai via GitGitGadget
2022-02-11 20:01 ` [PATCH v5 1/3] cat-file: rename cmdmode to transform_mode John Cai via GitGitGadget
2022-02-11 20:01 ` [PATCH v5 2/3] cat-file: introduce batch_mode enum to replace print_contents John Cai via GitGitGadget
2022-02-11 20:01 ` [PATCH v5 3/3] cat-file: add --batch-command mode John Cai via GitGitGadget
2022-02-14 13:59 ` Phillip Wood
2022-02-14 16:19 ` John Cai
2022-02-14 18:23 ` [PATCH v6 0/4] Add cat-file --batch-command flag John Cai via GitGitGadget
2022-02-14 18:23 ` [PATCH v6 1/4] cat-file: rename cmdmode to transform_mode John Cai via GitGitGadget
2022-02-14 18:23 ` [PATCH v6 2/4] cat-file: introduce batch_mode enum to replace print_contents John Cai via GitGitGadget
2022-02-14 18:23 ` [PATCH v6 3/4] cat-file: add remove_timestamp helper John Cai via GitGitGadget
2022-02-14 18:23 ` [PATCH v6 4/4] cat-file: add --batch-command mode John Cai via GitGitGadget
2022-02-15 19:39 ` Eric Sunshine
2022-02-15 22:58 ` John Cai
2022-02-15 23:20 ` Eric Sunshine
2022-02-16 0:53 ` [PATCH v7 0/4] Add cat-file --batch-command flag John Cai via GitGitGadget
2022-02-16 0:53 ` [PATCH v7 1/4] cat-file: rename cmdmode to transform_mode John Cai via GitGitGadget
2022-02-16 0:53 ` [PATCH v7 2/4] cat-file: introduce batch_mode enum to replace print_contents John Cai via GitGitGadget
2022-02-16 0:53 ` [PATCH v7 3/4] cat-file: add remove_timestamp helper John Cai via GitGitGadget
2022-02-16 0:53 ` [PATCH v7 4/4] cat-file: add --batch-command mode John Cai via GitGitGadget
2022-02-16 1:28 ` Junio C Hamano
2022-02-16 2:48 ` John Cai
2022-02-16 3:00 ` Junio C Hamano
2022-02-16 3:17 ` Eric Sunshine
2022-02-16 3:01 ` Eric Sunshine
2022-02-16 15:02 ` [PATCH v8 0/4] Add cat-file --batch-command flag John Cai via GitGitGadget
2022-02-16 15:02 ` [PATCH v8 1/4] cat-file: rename cmdmode to transform_mode John Cai via GitGitGadget
2022-02-16 15:02 ` [PATCH v8 2/4] cat-file: introduce batch_mode enum to replace print_contents John Cai via GitGitGadget
2022-02-16 15:02 ` [PATCH v8 3/4] cat-file: add remove_timestamp helper John Cai via GitGitGadget
2022-02-16 15:02 ` [PATCH v8 4/4] cat-file: add --batch-command mode John Cai via GitGitGadget
2022-02-16 17:15 ` Junio C Hamano
2022-02-16 17:25 ` Eric Sunshine
2022-02-16 20:30 ` John Cai
2022-02-16 20:59 ` [PATCH v9 0/4] Add cat-file --batch-command flag John Cai via GitGitGadget
2022-02-16 20:59 ` [PATCH v9 1/4] cat-file: rename cmdmode to transform_mode John Cai via GitGitGadget
2022-02-16 20:59 ` [PATCH v9 2/4] cat-file: introduce batch_mode enum to replace print_contents John Cai via GitGitGadget
2022-02-16 20:59 ` [PATCH v9 3/4] cat-file: add remove_timestamp helper John Cai via GitGitGadget
2022-02-16 20:59 ` [PATCH v9 4/4] cat-file: add --batch-command mode John Cai via GitGitGadget
2022-02-18 11:26 ` Phillip Wood [this message]
2022-02-18 16:53 ` John Cai
2022-02-18 17:32 ` Junio C Hamano
2022-02-18 17:23 ` Junio C Hamano
2022-02-18 18:23 ` [PATCH v10 0/4] Add cat-file --batch-command flag John Cai via GitGitGadget
2022-02-18 18:23 ` [PATCH v10 1/4] cat-file: rename cmdmode to transform_mode John Cai via GitGitGadget
2022-02-18 18:23 ` [PATCH v10 2/4] cat-file: introduce batch_mode enum to replace print_contents John Cai via GitGitGadget
2022-02-18 18:23 ` [PATCH v10 3/4] cat-file: add remove_timestamp helper John Cai via GitGitGadget
2022-02-19 6:33 ` Ævar Arnfjörð Bjarmason
2022-02-22 3:31 ` John Cai
2022-02-18 18:23 ` [PATCH v10 4/4] cat-file: add --batch-command mode John Cai via GitGitGadget
2022-02-19 6:35 ` Ævar Arnfjörð Bjarmason
2022-02-18 19:38 ` [PATCH v10 0/4] Add cat-file --batch-command flag Junio C Hamano
2022-02-22 11:07 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=095278d4-217b-7d97-5364-9cd491b34ed0@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=avarab@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=christian.couder@gmail.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=johncai86@gmail.com \
--cc=jonathantanmy@google.com \
--cc=me@ttaylorr.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).