RE: possible bug with commit-graph causing git to fork bomb (was Re: [External Mail]Re: Git fork process infinitely and never stop)

From: 程洋 <chengyang@xiaomi.com>
To: Carlo Arenas <carenas@gmail.com>, Han Xin <hanxin.hx@bytedance.com>
Cc: "bagasdotme@gmail.com" <bagasdotme@gmail.com>,
	"derrickstolee@github.com" <derrickstolee@github.com>,
	凡军辉 <fanjunhui@xiaomi.com>,
	"git@vger.kernel.org" <git@vger.kernel.org>,
	何浩 <hehao@xiaomi.com>,
	"lilinchao@oschina.cn" <lilinchao@oschina.cn>,
	"Xin7 Ma 马鑫" <maxin7@xiaomi.com>, 石奉兵 <shifengbing@xiaomi.com>
Subject: RE: possible bug with commit-graph causing git to fork bomb (was Re: [External Mail]Re: Git fork process infinitely and never stop)
Date: Tue, 27 Sep 2022 14:25:46 +0000	[thread overview]
Message-ID: <09cbcb88fb6643ad9d43ffc8f41eb360@xiaomi.com> (raw)
In-Reply-To: <CAPUEspiP=U+pBYm3tx1wPc46He=5WKkdFYCr-58a-UfhAD+PUg@mail.gmail.com>

I found another fork bomb with partial-clone but not related to commitGraph

Here is the video: https://youtu.be/3Xun4PQNQC4

And here is the tree command, GIT_TREACE2 and GIT_TRACE_PACKET log
https://drive.google.com/file/d/1mJ4-UcA8ytdjrYL7K6XxCtxys-DRRTqd/view?usp=sharing
https://drive.google.com/file/d/1rOlskap5l2Z1N6LnaBgLhW-G_UF8zx3Z/view?usp=sharing
https://drive.google.com/file/d/1zjI7Cm4aXv3fhPN3F_cwY15Ua-p4ncFl/view?usp=sharing

I still have the scene which can reproduce this bug. If there is something else I can provide, feel free to ask

>
> On Fri, Jul 8, 2022 at 5:52 PM Han Xin <hanxin.hx@bytedance.com> wrote:
> >
> > > > To be a supplement.
> > > > If I delete .git/objects/info/commit-graph,  everything works well
> > > > As well as fetch with `-c core.commitGraph=false`
> > >
> > > This would seem to indicate that something in the repository might
> > > be triggered by the commit-graph code.
> > >
> > > > if I execute `git fetch --filter=blob:none --quiet --progress miui --prune -
> -tags +refs/heads/*:refs/remotes/miui/* +refs/heads/miui13-s-thor-
> vendor-stable:refs/remotes/miui/miui13-s-thor-vendor-stable`  on version
> 2.25.1. It just throw error rather than infinite loop, like this youtube video
> "https://www.youtube.com/watch?v=qvYTvVRE0FU&feature=youtu.be"
> > >
> > > maybe a regression?
> > >
> > > Carlo
> >
> > I looks like the same issue I reported in [1], and we can see the
> > fixup in [2].
> >
> > 1.
> > https://lore.kernel.org/git/20220612161707.21807-1-chiyutianyi@gmail.c
> > om/ 2.
> > https://lore.kernel.org/git/cover.1656593279.git.hanxin.hx@bytedance.c
> > om/
>
> Indeed; and it is already integrated through hx/lookup-commit-in-graph-fix
> and merged all the way to "next", which would likely become 2.38 sometime
> soon.
>
> 程洋,
>
> if you could build a new git version based on next and confirm it solves your
> problem, it would help us all.
>
> Alternative can get that single "one line" patch[1] and integrate it on top of
> the git version you are using.
>
> Carlo
>
> [1]
> https://lore.kernel.org/git/96d4bb71505d87ed501c058bbd89bfc13d08b24a.1
> 656593279.git.hanxin.hx@bytedance.com/
#/******本邮件及其附件含有小米公司的保密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制、或散发）本邮件中的信息。如果您错收了本邮件，请您立即电话或邮件通知发件人并删除本邮件！ This e-mail and its attachments contain confidential information from XIAOMI, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!******/#