Re: [PATCH v3 0/5] Improve MyFirstContribution's GitGitGadget section

From: Philippe Blain <levraiphilippeblain@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Emily Shaffer <emilyshaffer@google.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Victoria Dye <vdye@github.com>,
	Eric Sunshine <sunshine@sunshineco.com>,
	Bagas Sanjaya <bagasdotme@gmail.com>,
	Philip Oakley <philipoakley@iee.email>
Subject: Re: [PATCH v3 0/5] Improve MyFirstContribution's GitGitGadget section
Date: Tue, 24 May 2022 08:29:51 -0400	[thread overview]
Message-ID: <0a2ab37e-58c0-378e-bc43-a935c8ebecec@gmail.com> (raw)
In-Reply-To: <xmqqy1yubb8j.fsf@gitster.g>

Hi Junio,

Le 2022-05-21 à 21:35, Junio C Hamano a écrit :
> Philippe Blain <levraiphilippeblain@gmail.com> writes:
> 
>>>> Philippe Blain (5):
>>>>   MyFirstContribution: add "Anatomy of a Patch Series" section
>>>>   MyFirstContribution: add standalone section on cover letter
>>>>   MyFirstContribution: reference "The cover letter" in "Preparing Email"
>>>>   MyFirstContribution: reference "The cover letter" in GitGitGadget
>>>>     section
>>>>   MyFirstContribution: drop PR description for GGG single-patch
>>>>     contributions
>> I just realized that the additional/tweaked content that I added in v3 went into 2/5
>> where as they should have gone into 1/5 (I'm talking about the changes 
>> *before* the "The cover letter" heading in [1]). I slightly messed up my rebase
>> it seems, I'm sorry... 
>>
>> Should I send a new version, or is it too late since it's now in 'next' ?
> 
> Thanks for letting me know, and sorry about the confusion.
> 
> Could you please send an incremental fix to be queued on top of
> these 5 patches?

I can't really send an incremental fix because the final content
as it is in 'next' already is OK; it's just that some content which was added
in patch 2/5 should have been added in 1/5 instead.

It's that too big of a deal, I just wanted to let you know.

Thanks,
Philippe.