From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C50D1C4363A for ; Tue, 27 Oct 2020 08:29:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 871F421D24 for ; Tue, 27 Oct 2020 08:29:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2894816AbgJ0I3X (ORCPT ); Tue, 27 Oct 2020 04:29:23 -0400 Received: from dd36226.kasserver.com ([85.13.153.21]:45522 "EHLO dd36226.kasserver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2894797AbgJ0I3W (ORCPT ); Tue, 27 Oct 2020 04:29:22 -0400 Received: from client3368.fritz.box (i5C7443F9.versanet.de [92.116.67.249]) by dd36226.kasserver.com (Postfix) with ESMTPSA id 9848F3C03C8; Tue, 27 Oct 2020 09:29:18 +0100 (CET) Subject: Re: [PATCH] Fix zsh installation instructions To: Felipe Contreras Cc: Junio C Hamano , Alexey via GitGitGadget , Git , Alexey References: From: Stefan Haller Message-ID: <0a5488b5-e39f-7b31-2a3a-db63c1fc99ab@haller-berlin.de> Date: Tue, 27 Oct 2020 09:29:17 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 25.10.20 4:29, Felipe Contreras wrote: > On Wed, Oct 14, 2020 at 12:39 PM Stefan Haller wrote: > >> Yes, the change is sane. The wrong file extension (.zsh vs. .bash) was a >> documentation bug that I had noticed myself, but forgot to submit a >> patch for. > > Yes, a patch was wrongly applied that changed it from .sh to .zsh. > >> The other hunk (adding compinit) is not so important to me; I suppose it >> was not in the original version because most zsh users already have this >> in their .zshrc anyway. But it's not wrong, and doesn't hurt to have >> here, I guess. > > If you don't have compinit, then how is the '_git' script being loaded > in the first place? >