From: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
To: Eric Sunshine <sunshine@sunshineco.com>,
Alexandr Miloslavskiy via GitGitGadget <gitgitgadget@gmail.com>
Cc: Git List <git@vger.kernel.org>,
Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com>,
Erik Faye-Lund <kusmabite@gmail.com>
Subject: Re: [PATCH v2] mingw: workaround for hangs when sending STDIN
Date: Mon, 17 Feb 2020 19:01:57 +0100 [thread overview]
Message-ID: <11825e4b-c92c-d5ad-9a6f-5fa89d48862c@syntevo.com> (raw)
In-Reply-To: <CAPig+cQWMvBi4vkAFMjV7LWjKJudja08ZqVMNfLfALxbBfpzXg@mail.gmail.com>
On 17.02.2020 18:24, Eric Sunshine wrote:
>> + x=0123456789abcde\n && # 16
>
> Did you intend for the \n in this assignment to be a literal newline?
> Every shell with which I tested treats it instead as an escaped 'n'.
I'm such a novice shell script writer :(
Yes, I intended a newline.
> By the way, are the embedded newlines actually important to the test
> itself, or are they just for human consumption if the test fails?I
> ask because I was curious about how other tests create large files,
> and found that a mechanism similar to your original (but without the
> pitfalls) has been used. For instance, t1050-large.sh uses:
>
> printf "%2000000s" X >large1 &&
>
> which is plenty portable and (presumably) doesn't have such demanding
> memory consumption.
They are not important to the test; the test only needs to internally
have a 8+ mb patch.
This only comes from my feeling that super-large lines could cause other
unexpected things, such as hitting various completely reasonable limits
and/or causing unwanted slowdowns. Frankly, I didn't test.
Frankly, I already had concerns about adding the test. Now I have
re-evaluated things and finally decided to move the test into commit
message instead. With it, all compatibility etc questions are resolved.
next prev parent reply other threads:[~2020-02-17 18:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 18:40 [PATCH] mingw: workaround for hangs when sending STDIN Alexandr Miloslavskiy via GitGitGadget
2020-02-13 18:41 ` Test program used to prove quota's behavior Alexandr Miloslavskiy
2020-02-13 18:56 ` [PATCH] mingw: workaround for hangs when sending STDIN Eric Sunshine
2020-02-13 19:22 ` Alexandr Miloslavskiy
2020-02-17 16:25 ` [PATCH v2] " Alexandr Miloslavskiy via GitGitGadget
2020-02-17 17:24 ` Eric Sunshine
2020-02-17 17:56 ` Junio C Hamano
2020-02-17 18:01 ` Alexandr Miloslavskiy [this message]
2020-02-17 18:01 ` [PATCH v3] " Alexandr Miloslavskiy via GitGitGadget
2020-02-18 16:39 ` Junio C Hamano
2020-02-27 21:15 ` Johannes Schindelin
2020-02-27 22:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11825e4b-c92c-d5ad-9a6f-5fa89d48862c@syntevo.com \
--to=alexandr.miloslavskiy@syntevo.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=kusmabite@gmail.com \
--cc=sunshine@sunshineco.com \
--cc=ungureanupaulsebastian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).