From: Thomas Rast <trast@student.ethz.ch>
To: git@vger.kernel.org
Cc: Eric Wong <normalperson@yhbt.net>, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/6] 'git svn info' fixes
Date: Tue, 26 Aug 2008 21:32:31 +0200 [thread overview]
Message-ID: <1219779157-31602-1-git-send-email-trast@student.ethz.ch> (raw)
Actually, I only wanted to do 5/6 (git svn info: make info relative to
the current directory). This seemed like a fairly simple change, see
the corresponding mail.
However, I also wanted to provide tests, and that's where the fun
started. Turns out t9119-git-svn-info.sh is currently quite broken.
1-4 just fix the tests; a brief summary:
[1/6] git svn info: tests: let 'init' test run with SVN 1.5
The tests do not report any problems with 1.5.
[2/6] git svn info: tests: do not use set -e
No idea how 'set -e' ever got in there; it completely breaks the
test script in case of an error.
[3/6] git svn info: tests: use test_cmp instead of git-diff
git-diff does not correctly report the exit status (IIRC that is
caused by the pager setup code?), which used to hide a lot of
errors.
[4/6] git svn info: tests: fix ptouch argument order in setup
Swapped arguments caused ptouch to fail and tests to break.
Yes, I'm just whoring commit karma here, so feel free to squash these
four into one if you like it better that way.
After these, 22 of 37 tests (all except --url, plus all unknown files)
fail. Most of them are caused by 'git svn info' not URL-encoding the
URL and Repository fields in the output, as SVN does. 6/6 fixes
this.
However, the unknown files tests still fail, simply because 'svn info'
itself fails on untracked files. It would be great if someone who is
still running SVN 1.4 could check whether that has been a bug in
git-svn all along, or is actually a behaviour change on the part of
SVN.
Oh, and let's hope I did the splitting right this time :-)
git-svn.perl | 30 +++++++++++--
t/t9119-git-svn-info.sh | 102 ++++++++++++++++++++++++++---------------------
2 files changed, 82 insertions(+), 50 deletions(-)
next reply other threads:[~2008-08-26 19:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 19:32 Thomas Rast [this message]
2008-08-26 19:32 ` [PATCH 1/6] git svn info: tests: let 'init' test run with SVN 1.5 Thomas Rast
2008-08-26 19:32 ` [PATCH 2/6] git svn info: tests: do not use set -e Thomas Rast
2008-08-26 19:32 ` [PATCH 3/6] git svn info: tests: use test_cmp instead of git-diff Thomas Rast
2008-08-26 19:32 ` [PATCH 4/6] git svn info: tests: fix ptouch argument order in setup Thomas Rast
2008-08-26 19:32 ` [PATCH 5/6] git svn info: make info relative to the current directory Thomas Rast
2008-08-26 19:32 ` [PATCH 6/6] git svn info: always quote URLs in 'info' output Thomas Rast
2008-08-27 9:43 ` Eric Wong
2008-08-27 9:53 ` [PATCH 0/6] 'git svn info' fixes Eric Wong
2008-08-28 8:30 ` Thomas Rast
2008-08-29 8:16 ` Eric Wong
2008-08-29 13:42 ` [PATCH 0/2] *** SUBJECT HERE *** Thomas Rast
2008-08-29 13:42 ` [PATCH 1/2] git-svn: match SVN 1.5 behaviour of info' on unknown item Thomas Rast
2008-08-29 13:42 ` [PATCH 2/2] git-svn: fix 'info' tests for unknown items Thomas Rast
2008-08-30 1:03 ` [PATCH 0/2] 'git svn info' fixes Eric Wong
2008-09-01 9:46 ` Thomas Rast
2008-09-01 22:58 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219779157-31602-1-git-send-email-trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).