From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg@dewire.com>,
Matthias Sohn <matthias.sohn@sap.com>
Cc: git@vger.kernel.org
Subject: [JGIT PATCH 2/7] Silence FindBugs "dubious use of GC" in PackFile.mmap
Date: Mon, 4 May 2009 16:30:43 -0700 [thread overview]
Message-ID: <1241479848-20687-2-git-send-email-spearce@spearce.org> (raw)
In-Reply-To: <1241479848-20687-1-git-send-email-spearce@spearce.org>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
.../findBugs/FindBugsExcludeFilter.xml | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/org.spearce.jgit/findBugs/FindBugsExcludeFilter.xml b/org.spearce.jgit/findBugs/FindBugsExcludeFilter.xml
index 526eb01..2af9348 100644
--- a/org.spearce.jgit/findBugs/FindBugsExcludeFilter.xml
+++ b/org.spearce.jgit/findBugs/FindBugsExcludeFilter.xml
@@ -6,4 +6,13 @@
<Method name="refreshPackedRefs" />
<Bug pattern="DM_STRING_CTOR" />
</Match>
+
+ <!-- Silence PackFile.mmap calls GC, we need to force it to remove stale
+ memory mapped segments if the JVM heap is out of address space.
+ -->
+ <Match>
+ <Class name="org.spearce.jgit.lib.PackFile" />
+ <Method name="mmap" />
+ <Bug pattern="DM_GC" />
+ </Match>
</FindBugsFilter>
--
1.6.3.rc4.206.g03e16
next prev parent reply other threads:[~2009-05-04 23:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-04 23:30 [JGIT PATCH 1/7] Fix FindBugs exclude filter to work on UNIX platforms Shawn O. Pearce
2009-05-04 23:30 ` Shawn O. Pearce [this message]
2009-05-04 23:30 ` [JGIT PATCH 3/7] Fix FindBugs String == is bad form Shawn O. Pearce
2009-05-04 23:30 ` [JGIT PATCH 4/7] Fix FindBugs load known null value Shawn O. Pearce
2009-05-04 23:30 ` [JGIT PATCH 5/7] FindBugs: Fix use of byte[].toString() in error messages Shawn O. Pearce
2009-05-04 23:30 ` [JGIT PATCH 6/7] Make TransportLocal.StreamRewritingThread static Shawn O. Pearce
2009-05-04 23:30 ` [JGIT PATCH 7/7] FindBugs: Disable clone() idiom tests Shawn O. Pearce
2009-05-06 11:18 ` [JGIT PATCH 1/7] Fix FindBugs exclude filter to work on UNIX platforms Sohn, Matthias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241479848-20687-2-git-send-email-spearce@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=matthias.sohn@sap.com \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).