From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: git@vger.kernel.org
Subject: [JGIT PATCH 1/2] Cleanup Transport.applyConfig to use setter methods more consistently
Date: Sat, 20 Jun 2009 18:21:55 -0700 [thread overview]
Message-ID: <1245547316-10299-1-git-send-email-spearce@spearce.org> (raw)
This just struck me as odd that we sometimes used a setter method,
and sometimes used direct assignment to the field. Now we use the
setter method if it is available. The fetch and push refspecs do
not have setters, so must still be done by direct field assignment.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
.../src/org/spearce/jgit/transport/Transport.java | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/Transport.java b/org.spearce.jgit/src/org/spearce/jgit/transport/Transport.java
index 1068f50..c36ccdd 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/transport/Transport.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/transport/Transport.java
@@ -568,9 +568,9 @@ public void setRemoveDeletedRefs(final boolean remove) {
*/
public void applyConfig(final RemoteConfig cfg) {
setOptionUploadPack(cfg.getUploadPack());
- fetch = cfg.getFetchRefSpecs();
+ setOptionReceivePack(cfg.getReceivePack());
setTagOpt(cfg.getTagOpt());
- optionReceivePack = cfg.getReceivePack();
+ fetch = cfg.getFetchRefSpecs();
push = cfg.getPushRefSpecs();
}
--
1.6.3.2.416.g04d0
next reply other threads:[~2009-06-21 1:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-21 1:21 Shawn O. Pearce [this message]
2009-06-21 1:21 ` [JGIT PATCH 2/2] Add support for remote.name.pushurl Shawn O. Pearce
2009-06-21 17:30 ` Robin Rosenberg
2009-06-23 16:50 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245547316-10299-1-git-send-email-spearce@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).