From: Tay Ray Chuan <rctay89@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Cc: "Jeff King" <peff@peff.net>,
"Sebastian Thiel" <byronimo@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: [PATCH 00/10] teach --progress to transport-related builtins
Date: Thu, 18 Feb 2010 20:37:01 +0800 [thread overview]
Message-ID: <1266496631-3980-1-git-send-email-rctay89@gmail.com> (raw)
This patch series adds --progress to:
- git-fetch
- git-pull
- git-push
I suspect the most contentious issue in this patch series would be the
logic that determines whether progress reporting is done. This is found
in patch 6 for transport.c::transport_set_verbosity().
As a guide, I used Jeff's message (gmane#121065). The rules used are as
follows (processing aborts when a rule is satisfied):
1. Report progress, if force_progress is 1 (ie. --progress).
2. Don't report progress, if verbosity < 0 (ie. -q/--quiet).
3. Report progress if isatty(2) is 1.
This changes the current implementation such that if both --progress
and --quiet are specified, progress is reported. I don't think this is
a very significant change, but I think it makes sense, since I expect
--progress to be mostly used by script writers or IDE integrators (to
force progress reporting even if stderr is not a terminal).
Contents:
[PATCH 01/10] Documentation/git-pull.txt: mention --quiet and --verbose for fetching
[PATCH 02/10] Documentation/git-push.txt: put --quiet before --verbose
[PATCH 03/10] fetch: refactor verbosity option handling into transport.[ch]
[PATCH 04/10] push: support multiple levels of verbosity
[PATCH 05/10] clone: support multiple levels of verbosity
[PATCH 06/10] transport->progress: use flag authoritatively
[PATCH 07/10] push: learn --progress
[PATCH 08/10] fetch: learn --progress
[PATCH 09/10] pull: learn --progress
[PATCH 10/10] transport: update flags to be in running order
Documentation/fetch-options.txt | 11 ++++++++---
Documentation/git-push.txt | 15 +++++++++++----
builtin-clone.c | 19 ++++++-------------
builtin-fetch.c | 7 +++----
builtin-push.c | 11 ++++++++---
git-pull.sh | 6 ++++--
transport-helper.c | 4 +---
transport.c | 31 ++++++++++++++++++++++++++-----
transport.h | 15 ++++++++++-----
9 files changed, 77 insertions(+), 42 deletions(-)
--
Cheers,
Ray Chuan
next reply other threads:[~2010-02-18 12:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 12:37 Tay Ray Chuan [this message]
2010-02-18 12:37 ` [PATCH 01/10] Documentation/git-pull.txt: mention --quiet and --verbose for fetching Tay Ray Chuan
2010-02-18 21:11 ` Junio C Hamano
2010-02-19 6:31 ` Tay Ray Chuan
2010-02-18 12:37 ` [PATCH 02/10] Documentation/git-push.txt: put --quiet before --verbose Tay Ray Chuan
2010-02-18 12:37 ` [PATCH 03/10] fetch: refactor verbosity option handling into transport.[ch] Tay Ray Chuan
2010-02-18 12:37 ` [PATCH 04/10] push: support multiple levels of verbosity Tay Ray Chuan
2010-02-18 12:37 ` [PATCH 05/10] clone: " Tay Ray Chuan
2010-02-18 12:37 ` [PATCH 06/10] transport->progress: use flag authoritatively Tay Ray Chuan
2010-02-18 12:37 ` [PATCH 07/10] push: learn --progress Tay Ray Chuan
2010-02-18 12:37 ` [PATCH 08/10] fetch: " Tay Ray Chuan
2010-02-18 12:37 ` [PATCH 09/10] pull: " Tay Ray Chuan
2010-02-18 12:37 ` [PATCH 10/10] transport: update flags to be in running order Tay Ray Chuan
2010-02-19 1:26 ` [PATCH 00/10] teach --progress to transport-related builtins Junio C Hamano
2010-02-19 6:31 ` Tay Ray Chuan
2010-02-19 7:53 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266496631-3980-1-git-send-email-rctay89@gmail.com \
--to=rctay89@gmail.com \
--cc=byronimo@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).