From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Git List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: [PATCH 6/6] remote.c: introduce branch.<name>.pushremote
Date: Fri, 22 Mar 2013 13:22:36 +0530 [thread overview]
Message-ID: <1363938756-13722-7-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <1363938756-13722-1-git-send-email-artagnon@gmail.com>
This new configuration variable overrides `remote.pushdefault` and
`branch.<name>.remote` for pushes. In a typical triangular-workflow
setup, you would want to set `remote.pushdefault` to specify the
remote to push to for all branches, and use this option to override it
for a specific branch.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
Documentation/config.txt | 18 ++++++++++++++----
remote.c | 4 ++++
t/t5516-fetch-push.sh | 15 +++++++++++++++
3 files changed, 33 insertions(+), 4 deletions(-)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index 09a8294..6595cd6 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -726,9 +726,18 @@ branch.<name>.remote::
When on branch <name>, it tells 'git fetch' and 'git push'
which remote to fetch from/push to. The remote to push to
may be overridden with `remote.pushdefault` (for all branches).
- If no remote is configured, or if you are not on any branch,
- it defaults to `origin` for fetching and `remote.pushdefault`
- for pushing.
+ The remote to push to, for the current branch, may be further
+ overridden by `branch.<name>.pushremote`. If no remote is
+ configured, or if you are not on any branch, it defaults to
+ `origin` for fetching and `remote.pushdefault` for pushing.
+
+branch.<name>.pushremote::
+ When on branch <name>, it overrides `branch.<name>.remote`
+ when pushing. It also overrides `remote.pushdefault` when
+ pushing from branch <name>. In a typical triangular-workflow
+ setup, you would want to set `remote.pushdefault` to specify
+ the remote to push to for all branches, and use this option to
+ override it for a specific branch.
branch.<name>.merge::
Defines, together with branch.<name>.remote, the upstream branch
@@ -1899,7 +1908,8 @@ receive.updateserverinfo::
remote.pushdefault::
The remote to push to by default. Overrides
- `branch.<name>.remote` for all branches.
+ `branch.<name>.remote` for all branches, and is overridden by
+ `branch.<name>.pushremote` for specific branches.
remote.<name>.url::
The URL of a remote repository. See linkgit:git-fetch[1] or
diff --git a/remote.c b/remote.c
index bdb542c..0be648d 100644
--- a/remote.c
+++ b/remote.c
@@ -368,6 +368,10 @@ static int handle_config(const char *key, const char *value, void *cb)
default_remote_name = branch->remote_name;
explicit_default_remote_name = 1;
}
+ } else if (!strcmp(subkey, ".pushremote")) {
+ if (branch == current_branch)
+ if (git_config_string(&pushremote_name, key, value))
+ return -1;
} else if (!strcmp(subkey, ".merge")) {
if (!value)
return config_error_nonbool(key);
diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh
index 63171f1..3f91874 100755
--- a/t/t5516-fetch-push.sh
+++ b/t/t5516-fetch-push.sh
@@ -539,6 +539,21 @@ test_expect_success 'push with config remote.*.pushurl' '
check_push_result $the_commit heads/master
'
+test_expect_success 'push with config branch.*.pushremote' '
+ mk_test_with_name up_repo heads/frotz &&
+ mk_test_with_name side_repo heads/quux &&
+ mk_test_with_name down_repo heads/master &&
+ test_config remote.up.url up_repo &&
+ test_config remote.pushdefault side_repo &&
+ test_config remote.down.url down_repo &&
+ test_config branch.master.remote up &&
+ test_config branch.master.pushremote down &&
+ git push &&
+ test_must_fail check_push_result_with_name up_repo $the_commit heads/master &&
+ test_must_fail check_push_result_with_name side_repo $the_commit heads/master &&
+ check_push_result_with_name down_repo $the_commit heads/master
+'
+
# clean up the cruft left with the previous one
git config --remove-section remote.there
--
1.8.2.62.ga35d936.dirty
next prev parent reply other threads:[~2013-03-22 7:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 7:52 [PATCH v3 0/6] Support triangular workflows Ramkumar Ramachandra
2013-03-22 7:52 ` [PATCH 1/6] remote.c: simplify a bit of code using git_config_string() Ramkumar Ramachandra
2013-03-22 18:26 ` Jonathan Nieder
2013-03-22 7:52 ` [PATCH 2/6] t5516 (fetch-push): update test description Ramkumar Ramachandra
2013-03-22 18:29 ` Jonathan Nieder
2013-03-22 7:52 ` [PATCH 3/6] t5516 (fetch-push): introduce mk_test_with_name() Ramkumar Ramachandra
2013-03-22 14:44 ` Jeff King
2013-03-22 14:52 ` Junio C Hamano
2013-03-22 14:59 ` Jeff King
2013-03-22 21:14 ` Jonathan Nieder
2013-03-28 13:03 ` Ramkumar Ramachandra
2013-03-22 14:54 ` Junio C Hamano
2013-03-22 14:58 ` Jeff King
2013-03-22 7:52 ` [PATCH 4/6] remote.c: introduce a way to have different remotes for fetch/push Ramkumar Ramachandra
2013-03-22 21:21 ` Jonathan Nieder
2013-03-22 22:13 ` Junio C Hamano
2013-03-22 23:41 ` Jonathan Nieder
2013-03-23 13:18 ` Ramkumar Ramachandra
2013-03-23 12:57 ` Ramkumar Ramachandra
2013-03-22 7:52 ` [PATCH 5/6] remote.c: introduce remote.pushdefault Ramkumar Ramachandra
2013-03-22 14:56 ` Jeff King
2013-03-27 9:39 ` Ramkumar Ramachandra
2013-03-22 7:52 ` Ramkumar Ramachandra [this message]
2013-03-22 17:37 ` [PATCH 6/6] remote.c: introduce branch.<name>.pushremote Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2013-04-02 7:40 [PATCH 0/6] Re-roll rr/triangle Ramkumar Ramachandra
2013-04-02 7:40 ` [PATCH 6/6] remote.c: introduce branch.<name>.pushremote Ramkumar Ramachandra
2013-03-28 13:26 [PATCH v4 0/6] Support triangular workflows Ramkumar Ramachandra
2013-03-28 13:26 ` [PATCH 6/6] remote.c: introduce branch.<name>.pushremote Ramkumar Ramachandra
2013-03-20 12:44 [PATCH v2 0/6] Support triangular workflows Ramkumar Ramachandra
2013-03-20 12:45 ` [PATCH 6/6] remote.c: introduce branch.<name>.pushremote Ramkumar Ramachandra
2013-03-20 13:03 ` Tay Ray Chuan
2013-03-20 13:35 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363938756-13722-7-git-send-email-artagnon@gmail.com \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).