From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?q?Nguy=E1=BB=85n=20Th=C3=A1i=20Ng=E1=BB=8Dc=20Duy?= 
	<pclouds@gmail.com>
Subject: [PATCH v3 2/2] log: add --show-linear-break to help see non-linear history
Date: Thu, 20 Mar 2014 12:44:14 +0700
Message-ID: <1395294254-941-2-git-send-email-pclouds@gmail.com>
References: <1395060676-23144-1-git-send-email-pclouds@gmail.com>
 <1395294254-941-1-git-send-email-pclouds@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Junio C Hamano <gitster@pobox.com>,
	=?UTF-8?q?Nguy=E1=BB=85n=20Th=C3=A1i=20Ng=E1=BB=8Dc=20Duy?= 
	<pclouds@gmail.com>
To: git@vger.kernel.org
X-From: git-owner@vger.kernel.org Thu Mar 20 06:44:40 2014
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@plane.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1WQVmQ-0003LC-DW
	for gcvg-git-2@plane.gmane.org; Thu, 20 Mar 2014 06:44:38 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753260AbaCTFoc convert rfc822-to-quoted-printable (ORCPT
	<rfc822;gcvg-git-2@m.gmane.org>); Thu, 20 Mar 2014 01:44:32 -0400
Received: from mail-pb0-f48.google.com ([209.85.160.48]:59114 "EHLO
	mail-pb0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753487AbaCTFo3 (ORCPT <rfc822;git@vger.kernel.org>);
	Thu, 20 Mar 2014 01:44:29 -0400
Received: by mail-pb0-f48.google.com with SMTP id md12so431254pbc.7
        for <git@vger.kernel.org>; Wed, 19 Mar 2014 22:44:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-type:content-transfer-encoding;
        bh=QRzzqgqSoSJlIIuKloUJ4iHtaHDbGFsXcf6Lq2Wt6ks=;
        b=rC8FywHgnBbgcZdRo3u2pM1M/Wgq6Q+SQg1ELm01tAxZ1cC0TuUAl0B1t8OsMrRdM3
         qTajk8dBd+J1c4bqmGOgy3+mzrFXIJvPYms6USg2wPQw/nicYZqwca9SdvvG3Vwwfn2q
         psGedMWNhTtj9PIxNh5Wu7MFpal/Spj8FHKgioASUb74SdhOhbCdjCy++5fO1F8dxr6w
         JZk64Ma3dFaDoOkkH+DXWbLdpo0r4TwBMR3IoIZLMRxzponjq1Wf0aVrGNhVnhEkDx0r
         JfcOQw2Pnlu8Xje/B4JeXTbE0H2web57FF4uIFYJUz4q/2+PQGNnK9FFMuGMPqhy0HIE
         0mtw==
X-Received: by 10.66.119.136 with SMTP id ku8mr44614721pab.121.1395294268573;
        Wed, 19 Mar 2014 22:44:28 -0700 (PDT)
Received: from pclouds@gmail.com ([14.161.32.83])
        by mx.google.com with ESMTPSA id id10sm1469329pbc.35.2014.03.19.22.44.24
        for <multiple recipients>
        (version=TLSv1 cipher=RC4-SHA bits=128/128);
        Wed, 19 Mar 2014 22:44:27 -0700 (PDT)
Received: by pclouds@gmail.com (sSMTP sendmail emulation); Thu, 20 Mar 2014 12:44:22 +0700
X-Mailer: git-send-email 1.9.0.201.g13d9d8b
In-Reply-To: <1395294254-941-1-git-send-email-pclouds@gmail.com>
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/244519>

Option explanation is in rev-list-options.txt. The interaction with -z
is left undecided.

Signed-off-by: Nguy=E1=BB=85n Th=C3=A1i Ng=E1=BB=8Dc Duy <pclouds@gmail=
=2Ecom>
---
 * Revert back to the old option name --show-linear-break
 * Get rid of saved_linear, use another flag in struct object instead
 * Fix not showing the break bar after a root commit if the dag graph
   has multiple roots
 * Make it work with --graph (although I don't really see the point of
   using both at the same time)
 * Let the next contributor deal with -z

 Documentation/rev-list-options.txt |  7 ++++++
 log-tree.c                         |  9 ++++++++
 object.h                           |  2 +-
 revision.c                         | 45 ++++++++++++++++++++++++++++++=
+++++---
 revision.h                         |  9 +++++++-
 5 files changed, 67 insertions(+), 5 deletions(-)

diff --git a/Documentation/rev-list-options.txt b/Documentation/rev-lis=
t-options.txt
index 9a3da36..b813961 100644
--- a/Documentation/rev-list-options.txt
+++ b/Documentation/rev-list-options.txt
@@ -758,6 +758,13 @@ This enables parent rewriting, see 'History Simpli=
fication' below.
 This implies the `--topo-order` option by default, but the
 `--date-order` option may also be specified.
=20
+--show-linear-break[=3D<barrier>]::
+	When --graph is not used, all history branches are flattened
+	which can make it hard to see that the two consecutive commits
+	do not belong to a linear branch. This option puts a barrier
+	in between them in that case. If `<barrier>` is specified, it
+	is the string that will be shown instead of the default one.
+
 ifdef::git-rev-list[]
 --count::
 	Print a number stating how many commits would have been
diff --git a/log-tree.c b/log-tree.c
index 5ce217d..c51a878 100644
--- a/log-tree.c
+++ b/log-tree.c
@@ -805,12 +805,21 @@ int log_tree_commit(struct rev_info *opt, struct =
commit *commit)
 	if (opt->line_level_traverse)
 		return line_log_print(opt, commit);
=20
+	if (opt->track_linear && !opt->linear && !opt->reverse_output_stage) =
{
+		if (opt->graph)
+			graph_show_padding(opt->graph);
+		else
+			puts("\n");
+		printf("%s\n", opt->break_bar);
+	}
 	shown =3D log_tree_diff(opt, commit, &log);
 	if (!shown && opt->loginfo && opt->always_show_header) {
 		log.parent =3D NULL;
 		show_log(opt);
 		shown =3D 1;
 	}
+	if (opt->track_linear && !opt->linear && opt->reverse_output_stage)
+		printf("\n%s\n", opt->break_bar);
 	opt->loginfo =3D NULL;
 	maybe_flush_or_die(stdout, "stdout");
 	return shown;
diff --git a/object.h b/object.h
index 768490b..9ee1959 100644
--- a/object.h
+++ b/object.h
@@ -28,7 +28,7 @@ struct object_array {
 #define TYPE_BITS   3
 /*
  * object flag allocation:
- * revision.h:      0------10
+ * revision.h:      0------10                 26
  * fetch-pack.c:    0---4
  * walker.c:        0-2
  * upload-pack.c:             11---------19
diff --git a/revision.c b/revision.c
index 78b5c3a..b9afdce 100644
--- a/revision.c
+++ b/revision.c
@@ -1831,6 +1831,18 @@ static int handle_revision_opt(struct rev_info *=
revs, int argc, const char **arg
 		revs->notes_opt.use_default_notes =3D 1;
 	} else if (!strcmp(arg, "--show-signature")) {
 		revs->show_signature =3D 1;
+	} else if (!strcmp(arg, "--show-linear-break") ||
+		   starts_with(arg, "--show-linear-break=3D")) {
+		if (starts_with(arg, "--show-linear-break=3D"))
+			revs->break_bar =3D xstrdup(arg + 20);
+		else
+			revs->break_bar =3D "                    ..........";
+		revs->track_linear =3D 1;
+		/*
+		 * make track_linear() not a break bar before the
+		 * first shown commit.
+		 */
+		commit_list_insert(NULL, &revs->previous_parents);
 	} else if (starts_with(arg, "--show-notes=3D") ||
 		   starts_with(arg, "--notes=3D")) {
 		struct strbuf buf =3D STRBUF_INIT;
@@ -2896,6 +2908,22 @@ enum commit_action simplify_commit(struct rev_in=
fo *revs, struct commit *commit)
 	return action;
 }
=20
+static void track_linear(struct rev_info *revs, struct commit *commit)
+{
+	struct commit_list *p;
+	for (p =3D revs->previous_parents; p; p =3D p->next)
+		if (p->item =3D=3D NULL || /* first commit */
+		    !hashcmp(p->item->object.sha1, commit->object.sha1))
+			break;
+	revs->linear =3D p !=3D NULL;
+	if (revs->reverse) {
+		if (revs->linear)
+			commit->object.flags |=3D TRACK_LINEAR;
+	}
+	free_commit_list(revs->previous_parents);
+	revs->previous_parents =3D copy_commit_list(commit->parents);
+}
+
 static struct commit *get_revision_1(struct rev_info *revs)
 {
 	if (!revs->commits)
@@ -2935,6 +2963,8 @@ static struct commit *get_revision_1(struct rev_i=
nfo *revs)
 			die("Failed to simplify parents of commit %s",
 			    sha1_to_hex(commit->object.sha1));
 		default:
+			if (revs->track_linear)
+				track_linear(revs, commit);
 			return commit;
 		}
 	} while (revs->commits);
@@ -3101,14 +3131,23 @@ struct commit *get_revision(struct rev_info *re=
vs)
 		revs->reverse_output_stage =3D 1;
 	}
=20
-	if (revs->reverse_output_stage)
-		return pop_commit(&revs->commits);
+	if (revs->reverse_output_stage) {
+		c =3D pop_commit(&revs->commits);
+		if (revs->track_linear)
+			revs->linear =3D !!(c && c->object.flags & TRACK_LINEAR);
+		return c;
+	}
=20
 	c =3D get_revision_internal(revs);
 	if (c && revs->graph)
 		graph_update(revs->graph, c);
-	if (!c)
+	if (!c) {
 		free_saved_parents(revs);
+		if (revs->previous_parents) {
+			free_commit_list(revs->previous_parents);
+			revs->previous_parents =3D NULL;
+		}
+	}
 	return c;
 }
=20
diff --git a/revision.h b/revision.h
index 0262bbd..64503e9 100644
--- a/revision.h
+++ b/revision.h
@@ -19,7 +19,8 @@
 #define SYMMETRIC_LEFT	(1u<<8)
 #define PATCHSAME	(1u<<9)
 #define BOTTOM		(1u<<10)
-#define ALL_REV_FLAGS	((1u<<11)-1)
+#define TRACK_LINEAR	(1u<<26)
+#define ALL_REV_FLAGS	(((1u<<11)-1) | TRACK_LINEAR)
=20
 #define DECORATE_SHORT_REFS	1
 #define DECORATE_FULL_REFS	2
@@ -138,6 +139,9 @@ struct rev_info {
 			preserve_subject:1;
 	unsigned int	disable_stdin:1;
 	unsigned int	leak_pending:1;
+	/* --show-linear-break */
+	unsigned int	track_linear:1,
+			linear:1;
=20
 	enum date_mode date_mode;
=20
@@ -198,6 +202,9 @@ struct rev_info {
=20
 	/* copies of the parent lists, for --full-diff display */
 	struct saved_parents *saved_parents_slab;
+
+	struct commit_list *previous_parents;
+	const char *break_bar;
 };
=20
 extern int ref_excluded(struct string_list *, const char *path);
--=20
1.9.0.201.g13d9d8b