From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 010/144] t0010-racy-git.sh: use the $( ... ) construct for command substitution Date: Tue, 25 Mar 2014 01:24:15 -0700 Message-ID: <1395735989-3396-11-git-send-email-gitter.spiros@gmail.com> References: <1395735989-3396-1-git-send-email-gitter.spiros@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Mar 25 09:38:02 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WSMrx-0002zh-4r for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 09:38:01 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754161AbaCYIhz convert rfc822-to-quoted-printable (ORCPT ); Tue, 25 Mar 2014 04:37:55 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:49605 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753652AbaCYI0u (ORCPT ); Tue, 25 Mar 2014 04:26:50 -0400 Received: by mail-pa0-f50.google.com with SMTP id kq14so124630pab.37 for ; Tue, 25 Mar 2014 01:26:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=HbwT0jzNTLb/rs8LlJeI3gn57gNtruWdFQV2bTGJYYc=; b=H/RdHFkMI2nl0sGH6GEHwDeAiaufj3r7i+BkT05fi4A4Qp75FyJ+u2zXe3Q7bACiQQ paQO4rzXcO2kcs4Ok7a40RbKeo1FYeoiQatucGaG0vh69xXsyR6tE8JxwwsSKmKMXoU1 8qIArtkGHrSjtddgQO3R/bmKsduuEVt6smLk/dj72XAx2nJnoFIq7VqyxTkeGO8sP2BK 5BExo4dImurS+pKyetemmyrhUaNJCJjQWa6MQAluv3G0iUPs9efk3BV2vmajaT314Dpm S222F4bL7K3/ADS+kSvvQ6HywHoUxTi26XBzJ2gAOMga/cqKO+5Qa5j5DUn5BnHQy3B1 50zA== X-Received: by 10.68.196.226 with SMTP id ip2mr76422889pbc.106.1395736010574; Tue, 25 Mar 2014 01:26:50 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id pr4sm41327198pbb.53.2014.03.25.01.26.49 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Mar 2014 01:26:50 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395735989-3396-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However,all but the simplest uses become complicated quickly. In particular,embedded command substitutions and/or the use of double quotes require careful escaping with the backs= lash character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea= ture from the Korn shell. Signed-off-by: Elia Pinto --- t/t0010-racy-git.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t0010-racy-git.sh b/t/t0010-racy-git.sh index e45a9e4..5657c5a 100755 --- a/t/t0010-racy-git.sh +++ b/t/t0010-racy-git.sh @@ -14,7 +14,7 @@ do git update-index --add infocom echo xyzzy >infocom =20 - files=3D`git diff-files -p` + files=3D$(git diff-files -p) test_expect_success \ "Racy GIT trial #$trial part A" \ 'test "" !=3D "$files"' @@ -23,7 +23,7 @@ do echo xyzzy >cornerstone git update-index --add cornerstone =20 - files=3D`git diff-files -p` + files=3D$(git diff-files -p) test_expect_success \ "Racy GIT trial #$trial part B" \ 'test "" !=3D "$files"' --=20 1.7.10.4