From mboxrd@z Thu Jan  1 00:00:00 1970
From: Elia Pinto <gitter.spiros@gmail.com>
Subject: [PATCH v2 009/142] t0001-init.sh: use the $( ... ) construct for command substitution
Date: Tue, 25 Mar 2014 10:22:30 -0700
Message-ID: <1395768283-31135-10-git-send-email-gitter.spiros@gmail.com>
References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Elia Pinto <gitter.spiros@gmail.com>
To: git@vger.kernel.org
X-From: git-owner@vger.kernel.org Tue Mar 25 18:25:36 2014
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@plane.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1WSV6J-0005m3-E1
	for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:25:23 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755318AbaCYRZF convert rfc822-to-quoted-printable (ORCPT
	<rfc822;gcvg-git-2@m.gmane.org>); Tue, 25 Mar 2014 13:25:05 -0400
Received: from mail-pd0-f170.google.com ([209.85.192.170]:38176 "EHLO
	mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755296AbaCYRY6 (ORCPT <rfc822;git@vger.kernel.org>);
	Tue, 25 Mar 2014 13:24:58 -0400
Received: by mail-pd0-f170.google.com with SMTP id v10so722441pde.29
        for <git@vger.kernel.org>; Tue, 25 Mar 2014 10:24:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-type:content-transfer-encoding;
        bh=OYreVkK8kLZZ5d+00Yo81zQfJ0o1MkuH2MFZ4o9kGPg=;
        b=OjtJMlb/aUrwn4Q7fzFp06jJi8ElVtEBlVr2rgCOaZudYO+npKXPFx2bH9pDw9X0RO
         rsT+Em5FPuNqnDENErJTSdtyxg4TiOfDYPjwxSPDDMHr5KOdtB5PddPJwbT+9qpfGqAa
         SCfq0xzV464C1ILljwY5d7iouhh4motrT28ha9vG6yO+oDzDpR2RrIlUCsItdB9tPjYZ
         3ZBRgnX8zmWmigiyYXDPYeIVXCTbSBoAx2KN02Y1XOgZ/1WYoCXlZrcT7q2PPLGXxqGm
         SHe/JnIUpNxdE7DUYkKKQ9cHsXAjrMIlMlUUPQiM4q7+VlNG2jNQckcpQ1jgz/CQwLzS
         +fRg==
X-Received: by 10.68.217.234 with SMTP id pb10mr17540183pbc.142.1395768297574;
        Tue, 25 Mar 2014 10:24:57 -0700 (PDT)
Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140])
        by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.24.56
        for <multiple recipients>
        (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
        Tue, 25 Mar 2014 10:24:57 -0700 (PDT)
X-Mailer: git-send-email 1.7.10.4
In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/245058>

The Git CodingGuidelines prefer the $( ... ) construct for command
substitution instead of using the back-quotes, or grave accents (`..`).

The backquoted form is the historical method for command substitution,
and is supported by POSIX. However, all but the simplest uses become
complicated quickly. In particular, embedded command substitutions
and/or the use of double quotes require careful escaping with the backs=
lash
character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea=
ture from
the Korn shell.

The patch was generated by the simple script

for _f in $(find . -name "*.sh")
do
=C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 t/t0001-init.sh |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/t/t0001-init.sh b/t/t0001-init.sh
index 9fb582b..32821fe 100755
--- a/t/t0001-init.sh
+++ b/t/t0001-init.sh
@@ -250,7 +250,7 @@ test_expect_success 'init --bare/--shared overrides=
 system/global config' '
 	) &&
 	check_config init-bare-shared-override true unset &&
 	test x0666 =3D \
-	x`git config -f init-bare-shared-override/config core.sharedRepositor=
y`
+	x$(git config -f init-bare-shared-override/config core.sharedReposito=
ry)
 '
=20
 test_expect_success 'init honors global core.sharedRepository' '
@@ -262,7 +262,7 @@ test_expect_success 'init honors global core.shared=
Repository' '
 		git init
 	) &&
 	test x0666 =3D \
-	x`git config -f shared-honor-global/.git/config core.sharedRepository=
`
+	x$(git config -f shared-honor-global/.git/config core.sharedRepositor=
y)
 '
=20
 test_expect_success 'init rejects insanely long --template' '
@@ -374,7 +374,7 @@ test_expect_success 'init prefers command line to G=
IT_DIR' '
 test_expect_success 'init with separate gitdir' '
 	rm -rf newdir &&
 	git init --separate-git-dir realgitdir newdir &&
-	echo "gitdir: `pwd`/realgitdir" >expected &&
+	echo "gitdir: $(pwd)/realgitdir" >expected &&
 	test_cmp expected newdir/.git &&
 	test -d realgitdir/refs
 '
@@ -388,7 +388,7 @@ test_expect_success 're-init to update git link' '
 	cd newdir &&
 	git init --separate-git-dir ../surrealgitdir
 	) &&
-	echo "gitdir: `pwd`/surrealgitdir" >expected &&
+	echo "gitdir: $(pwd)/surrealgitdir" >expected &&
 	test_cmp expected newdir/.git &&
 	test -d surrealgitdir/refs &&
 	! test -d realgitdir/refs
@@ -401,7 +401,7 @@ test_expect_success 're-init to move gitdir' '
 	cd newdir &&
 	git init --separate-git-dir ../realgitdir
 	) &&
-	echo "gitdir: `pwd`/realgitdir" >expected &&
+	echo "gitdir: $(pwd)/realgitdir" >expected &&
 	test_cmp expected newdir/.git &&
 	test -d realgitdir/refs
 '
@@ -415,7 +415,7 @@ test_expect_success SYMLINKS 're-init to move gitdi=
r symlink' '
 	ln -s here .git &&
 	git init --separate-git-dir ../realgitdir
 	) &&
-	echo "gitdir: `pwd`/realgitdir" >expected &&
+	echo "gitdir: $(pwd)/realgitdir" >expected &&
 	test_cmp expected newdir/.git &&
 	test -d realgitdir/refs &&
 	! test -d newdir/here
--=20
1.7.10.4