From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH v2 001/142] check-builtins.sh: use the $( ... ) construct for command substitution Date: Tue, 25 Mar 2014 10:22:22 -0700 Message-ID: <1395768283-31135-2-git-send-email-gitter.spiros@gmail.com> References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Mar 25 18:37:27 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WSVHq-0001NU-OV for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:37:19 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755290AbaCYRYv convert rfc822-to-quoted-printable (ORCPT ); Tue, 25 Mar 2014 13:24:51 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:59644 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753002AbaCYRYt (ORCPT ); Tue, 25 Mar 2014 13:24:49 -0400 Received: by mail-pa0-f53.google.com with SMTP id ld10so728701pab.26 for ; Tue, 25 Mar 2014 10:24:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=y+wq4mEa60m2TUlZIxvvSm6U0MlPMEhISpydRKTShSo=; b=lQDJ+9qYcrHl81laYjeDM8aVBAtp14x1f/0CDKyou7wlxrMXZSe4ZLlN8sEaO/Y0Cs C1Qgsh/59Ek/SYWp2A2LoNAGApz971L7iRFgZf85fd09Cp8R9uEI8/3z1M2D0cMBKVPh scQcfaKeUEurO131e85K8vg7xzQA/odpsYPoweSTH8DjYVAF1S5My8p4GjTw07u3/1DF eZCnpDvdxqESRuUrMwT/zma0EddBXf2cM+xEP7RNy9ewdF4+dLnVfkeovd96/vkRbnYQ z3WBijUTWMsuUsw1fH6OYBhKEncqD23UrkkXu+/mmp6PVuD/ngNsxqm3fFaYcdaLzcsm DNkQ== X-Received: by 10.68.136.162 with SMTP id qb2mr79119581pbb.88.1395768288598; Tue, 25 Mar 2014 10:24:48 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.24.47 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Mar 2014 10:24:48 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backs= lash character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea= ture from the Korn shell. The patch was generated by the simple script for _f in $(find . -name "*.sh") do =C2=A0 sed -i 's@`$.*$`@$(\1)@g' ${_f} done Signed-off-by: Elia Pinto --- check-builtins.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/check-builtins.sh b/check-builtins.sh index d6fe6cf..07cff69 100755 --- a/check-builtins.sh +++ b/check-builtins.sh @@ -14,8 +14,8 @@ sort | bad=3D0 while read builtin do - base=3D`expr "$builtin" : 'git-$.*$'` - x=3D`sed -ne 's/.*{ "'$base'", $cmd_[^, ]*$.*/'$base' \1/p' git.c` + base=3D$(expr "$builtin" : 'git-$.*$') + x=3D$(sed -ne 's/.*{ "'$base'", $cmd_[^, ]*$.*/'$base' \1/p' git.c) if test -z "$x" then echo "$base is builtin but not listed in git.c command list" --=20 1.7.10.4