From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH v2 025/142] t1410-reflog.sh: use the $( ... ) construct for command substitution Date: Tue, 25 Mar 2014 10:22:46 -0700 Message-ID: <1395768283-31135-26-git-send-email-gitter.spiros@gmail.com> References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Mar 25 18:33:46 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WSVE9-0004n1-4U for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:33:29 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932110AbaCYRZW convert rfc822-to-quoted-printable (ORCPT ); Tue, 25 Mar 2014 13:25:22 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:46539 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755349AbaCYRZU (ORCPT ); Tue, 25 Mar 2014 13:25:20 -0400 Received: by mail-pa0-f47.google.com with SMTP id lj1so740504pab.20 for ; Tue, 25 Mar 2014 10:25:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=28jTDcPElsFVnK+O7Coug+O37ZDrxGx8OqAuDdaO+8k=; b=YFQO8TYyYxqoo4i+EdsUDpGVA+Bji1r+8r/pVoCumeStFEMgaBu4TZMpAZ47CXCaWM eztKW+Gm0Cl/xMUhQ59SCZS2Km0UxQxuoVUxDh7BvUmExvCHcTcw+2IX9oJ6RMMFF0/r KnZC7caRBFzPZriZKLK0ei0n2wopzbjPsDSTwoTnDB6tRotTTUPmjN8Q9QozOsdfA3QB A1oZTbjrbxleBCZd/kHD8YhFWpJQk6/UY2SaB8Hg3f2g4HJffqyg+cEEd8lAlAFDtQaQ LlZL94eBAjatBCg/O/qoY+jfkwvR+qbD9SEIIGyuOOErMdg+BxFm8BP0FwgZ8cPXJc6j ynZQ== X-Received: by 10.67.2.34 with SMTP id bl2mr80007502pad.58.1395768318664; Tue, 25 Mar 2014 10:25:18 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.25.17 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Mar 2014 10:25:18 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backs= lash character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea= ture from the Korn shell. The patch was generated by the simple script for _f in $(find . -name "*.sh") do =C2=A0 sed -i 's@`$.*$`@$(\1)@g' ${_f} done Signed-off-by: Elia Pinto --- t/t1410-reflog.sh | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/t/t1410-reflog.sh b/t/t1410-reflog.sh index 236b13a..0a9502a 100755 --- a/t/t1410-reflog.sh +++ b/t/t1410-reflog.sh @@ -62,18 +62,18 @@ test_expect_success setup ' git add . && =20 test_tick && git commit -m rabbit && - H=3D`git rev-parse --verify HEAD` && - A=3D`git rev-parse --verify HEAD:A` && - B=3D`git rev-parse --verify HEAD:A/B` && - C=3D`git rev-parse --verify HEAD:C` && - D=3D`git rev-parse --verify HEAD:A/D` && - E=3D`git rev-parse --verify HEAD:A/B/E` && + H=3D$(git rev-parse --verify HEAD) && + A=3D$(git rev-parse --verify HEAD:A) && + B=3D$(git rev-parse --verify HEAD:A/B) && + C=3D$(git rev-parse --verify HEAD:C) && + D=3D$(git rev-parse --verify HEAD:A/D) && + E=3D$(git rev-parse --verify HEAD:A/B/E) && check_fsck && =20 test_chmod +x C && git add C && test_tick && git commit -m dragon && - L=3D`git rev-parse --verify HEAD` && + L=3D$(git rev-parse --verify HEAD) && check_fsck && =20 rm -f C A/B/E && @@ -81,15 +81,15 @@ test_expect_success setup ' echo horse >A/G && git add F A/G && test_tick && git commit -a -m sheep && - F=3D`git rev-parse --verify HEAD:F` && - G=3D`git rev-parse --verify HEAD:A/G` && - I=3D`git rev-parse --verify HEAD:A` && - J=3D`git rev-parse --verify HEAD` && + F=3D$(git rev-parse --verify HEAD:F) && + G=3D$(git rev-parse --verify HEAD:A/G) && + I=3D$(git rev-parse --verify HEAD:A) && + J=3D$(git rev-parse --verify HEAD) && check_fsck && =20 rm -f A/G && test_tick && git commit -a -m monkey && - K=3D`git rev-parse --verify HEAD` && + K=3D$(git rev-parse --verify HEAD) && check_fsck && =20 check_have A B C D E F G H I J K L && --=20 1.7.10.4