From mboxrd@z Thu Jan  1 00:00:00 1970
From: Elia Pinto <gitter.spiros@gmail.com>
Subject: [PATCH v2 026/142] t1511-rev-parse-caret.sh: use the $( ... ) construct for command substitution
Date: Tue, 25 Mar 2014 10:22:47 -0700
Message-ID: <1395768283-31135-27-git-send-email-gitter.spiros@gmail.com>
References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Elia Pinto <gitter.spiros@gmail.com>
To: git@vger.kernel.org
X-From: git-owner@vger.kernel.org Tue Mar 25 18:33:43 2014
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@plane.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1WSVE6-0004n1-W1
	for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:33:27 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755354AbaCYRZX convert rfc822-to-quoted-printable (ORCPT
	<rfc822;gcvg-git-2@m.gmane.org>); Tue, 25 Mar 2014 13:25:23 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:58935 "EHLO
	mail-pb0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755351AbaCYRZU (ORCPT <rfc822;git@vger.kernel.org>);
	Tue, 25 Mar 2014 13:25:20 -0400
Received: by mail-pb0-f45.google.com with SMTP id uo5so743562pbc.32
        for <git@vger.kernel.org>; Tue, 25 Mar 2014 10:25:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-type:content-transfer-encoding;
        bh=aDFTYdekXPCQFXhem/s37sNktezYD7Iq/3YQcxNUQAc=;
        b=R1VcV1ccRlx3+ouznbk5Mz6sZO6B7tYHbd89fzj03cizcAKnI8CSbREn057Y7yiB5l
         onKVOBVKmOyAd8+frnxOiUHNdk5CqndZWsYTs4gt3kge+qNlF2ihsg1c6PJG+abZyvgp
         dLacmNP0Wr75rVioU0DZbujc7IB21M9NQMHZy6JXR7hLeM2BZr0kXpHsb6g061pg3bQx
         sV7CtmNDXBHt/4VSifmZagtYNcrxIFrBWH4u9hwXdrcH5HjEFPpOLZ0GFzFaLjnXErRO
         jSj78hJDKArRe7Dc8EKHZvbiEBTHEoH1zqkuo3HjLaN5urt1uDvy9gzm/Zf5Rjll+8xf
         2GmQ==
X-Received: by 10.67.4.169 with SMTP id cf9mr80315312pad.45.1395768319596;
        Tue, 25 Mar 2014 10:25:19 -0700 (PDT)
Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140])
        by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.25.18
        for <multiple recipients>
        (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
        Tue, 25 Mar 2014 10:25:19 -0700 (PDT)
X-Mailer: git-send-email 1.7.10.4
In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/245124>

The Git CodingGuidelines prefer the $( ... ) construct for command
substitution instead of using the back-quotes, or grave accents (`..`).

The backquoted form is the historical method for command substitution,
and is supported by POSIX. However, all but the simplest uses become
complicated quickly. In particular, embedded command substitutions
and/or the use of double quotes require careful escaping with the backs=
lash
character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea=
ture from
the Korn shell.

The patch was generated by the simple script

for _f in $(find . -name "*.sh")
do
=C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 t/t1511-rev-parse-caret.sh |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/t1511-rev-parse-caret.sh b/t/t1511-rev-parse-caret.sh
index 15973f2..7043ba7 100755
--- a/t/t1511-rev-parse-caret.sh
+++ b/t/t1511-rev-parse-caret.sh
@@ -6,11 +6,11 @@ test_description=3D'tests for ref^{stuff}'
=20
 test_expect_success 'setup' '
 	echo blob >a-blob &&
-	git tag -a -m blob blob-tag `git hash-object -w a-blob` &&
+	git tag -a -m blob blob-tag $(git hash-object -w a-blob) &&
 	mkdir a-tree &&
 	echo moreblobs >a-tree/another-blob &&
 	git add . &&
-	TREE_SHA1=3D`git write-tree` &&
+	TREE_SHA1=3D$(git write-tree) &&
 	git tag -a -m tree tree-tag "$TREE_SHA1" &&
 	git commit -m Initial &&
 	git tag -a -m commit commit-tag &&
--=20
1.7.10.4