From mboxrd@z Thu Jan  1 00:00:00 1970
From: Elia Pinto <gitter.spiros@gmail.com>
Subject: [PATCH v2 027/142] t1512-rev-parse-disambiguation.sh: use the $( ... ) construct for command substitution
Date: Tue, 25 Mar 2014 10:22:48 -0700
Message-ID: <1395768283-31135-28-git-send-email-gitter.spiros@gmail.com>
References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Elia Pinto <gitter.spiros@gmail.com>
To: git@vger.kernel.org
X-From: git-owner@vger.kernel.org Tue Mar 25 18:32:46 2014
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@plane.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1WSVDO-0004n1-BS
	for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:32:42 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932112AbaCYRZZ convert rfc822-to-quoted-printable (ORCPT
	<rfc822;gcvg-git-2@m.gmane.org>); Tue, 25 Mar 2014 13:25:25 -0400
Received: from mail-pa0-f46.google.com ([209.85.220.46]:59046 "EHLO
	mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932102AbaCYRZV (ORCPT <rfc822;git@vger.kernel.org>);
	Tue, 25 Mar 2014 13:25:21 -0400
Received: by mail-pa0-f46.google.com with SMTP id kp14so739133pab.33
        for <git@vger.kernel.org>; Tue, 25 Mar 2014 10:25:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-type:content-transfer-encoding;
        bh=FeX2Q982LokWlez8UDP3BOlx8Ld5nDo+79JtQKvghow=;
        b=FLJrOvqNURqFLhFn7L+PRstdSV5GRXh6xES83p3RfUcrNJ8Gs+CfjBYWKP+Es8lfBG
         WvQ0MA/no15FF/QWEAkbKWkzoclt+tFrTmwxc7lclFhvftuJByrJO7O6765RUCal0RT9
         u2ya8XKFsoXQzK/8jeoWlk5JgklfZPIkOAoy+eRlgDbVy+lorO2S0bOyRLZOQBT0hcKB
         cPVjx/+LRzumGfDZ7E65HxODL82P0x2q45SacIwGNNBWs9+qrdZH3VWDdYZ2bdeI5Epl
         /EakDNNzwUHbyyVSclS3G2YAyl36/weTgCm33du98W3OLm0gP80oWv+F5phZKsUYMc6R
         ZC5w==
X-Received: by 10.68.159.228 with SMTP id xf4mr80417796pbb.74.1395768320920;
        Tue, 25 Mar 2014 10:25:20 -0700 (PDT)
Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140])
        by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.25.19
        for <multiple recipients>
        (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
        Tue, 25 Mar 2014 10:25:20 -0700 (PDT)
X-Mailer: git-send-email 1.7.10.4
In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/245063>

The Git CodingGuidelines prefer the $( ... ) construct for command
substitution instead of using the back-quotes, or grave accents (`..`).

The backquoted form is the historical method for command substitution,
and is supported by POSIX. However, all but the simplest uses become
complicated quickly. In particular, embedded command substitutions
and/or the use of double quotes require careful escaping with the backs=
lash
character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea=
ture from
the Korn shell.

The patch was generated by the simple script

for _f in $(find . -name "*.sh")
do
=C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 t/t1512-rev-parse-disambiguation.sh |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/t/t1512-rev-parse-disambiguation.sh b/t/t1512-rev-parse-di=
sambiguation.sh
index 4a155c8..e221167 100755
--- a/t/t1512-rev-parse-disambiguation.sh
+++ b/t/t1512-rev-parse-disambiguation.sh
@@ -275,19 +275,19 @@ test_expect_success 'rev-parse --disambiguate' '
=20
 test_expect_success 'ambiguous 40-hex ref' '
 	TREE=3D$(git mktree </dev/null) &&
-	REF=3D`git rev-parse HEAD` &&
+	REF=3D$(git rev-parse HEAD) &&
 	VAL=3D$(git commit-tree $TREE </dev/null) &&
 	git update-ref refs/heads/$REF $VAL &&
-	test `git rev-parse $REF 2>err` =3D $REF &&
+	test $(git rev-parse $REF 2>err) =3D $REF &&
 	grep "refname.*${REF}.*ambiguous" err
 '
=20
 test_expect_success 'ambiguous short sha1 ref' '
 	TREE=3D$(git mktree </dev/null) &&
-	REF=3D`git rev-parse --short HEAD` &&
+	REF=3D$(git rev-parse --short HEAD) &&
 	VAL=3D$(git commit-tree $TREE </dev/null) &&
 	git update-ref refs/heads/$REF $VAL &&
-	test `git rev-parse $REF 2>err` =3D $VAL &&
+	test $(git rev-parse $REF 2>err) =3D $VAL &&
 	grep "refname.*${REF}.*ambiguous" err
 '
=20
--=20
1.7.10.4