From mboxrd@z Thu Jan  1 00:00:00 1970
From: Elia Pinto <gitter.spiros@gmail.com>
Subject: [PATCH v2 029/142] t3030-merge-recursive.sh: use the $( ... ) construct for command substitution
Date: Tue, 25 Mar 2014 10:22:50 -0700
Message-ID: <1395768283-31135-30-git-send-email-gitter.spiros@gmail.com>
References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Elia Pinto <gitter.spiros@gmail.com>
To: git@vger.kernel.org
X-From: git-owner@vger.kernel.org Tue Mar 25 18:33:42 2014
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@plane.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1WSVE7-0004n1-Gg
	for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:33:27 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755600AbaCYRcm convert rfc822-to-quoted-printable (ORCPT
	<rfc822;gcvg-git-2@m.gmane.org>); Tue, 25 Mar 2014 13:32:42 -0400
Received: from mail-pb0-f48.google.com ([209.85.160.48]:38002 "EHLO
	mail-pb0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754665AbaCYRZX (ORCPT <rfc822;git@vger.kernel.org>);
	Tue, 25 Mar 2014 13:25:23 -0400
Received: by mail-pb0-f48.google.com with SMTP id md12so743272pbc.7
        for <git@vger.kernel.org>; Tue, 25 Mar 2014 10:25:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-type:content-transfer-encoding;
        bh=ouAVpT+uxI+C4BVfqU7iVtYbZ+VmO8hpVJkrVnjz6zY=;
        b=N46nj0EP6x8eSxAMFjSadCYW+km6Orq36f89i/95vxr/ldmfzZZPzK9FPOZI7XEQhp
         dq4zi2sFSXdp54JhfQmjECxiRWdc+w8o5H01Dd2xrZUDmSiKH4Y/gC2WztKN9TpdSF1E
         OcTaNP4FMGMzwo5fNVdkZgQyhc2OdY49lqEMlMXwslfDdyR4L0pgP3cQ5kLIfXXaxXkP
         KuqqlDn2243W+STsaXaRbsLOEOHNRwPqRFnhAZGBn8CAowTxckKfLOCsZ7A7MegJ3VGw
         AAQVeLDbszUcetWcHnY4dUXZYAKrdgQeEo/PGWV93dbQH8XiOh2VAD/wFjBDmx+aP/1Z
         o/kA==
X-Received: by 10.66.161.38 with SMTP id xp6mr12372038pab.145.1395768323088;
        Tue, 25 Mar 2014 10:25:23 -0700 (PDT)
Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140])
        by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.25.21
        for <multiple recipients>
        (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
        Tue, 25 Mar 2014 10:25:22 -0700 (PDT)
X-Mailer: git-send-email 1.7.10.4
In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/245122>

The Git CodingGuidelines prefer the $( ... ) construct for command
substitution instead of using the back-quotes, or grave accents (`..`).

The backquoted form is the historical method for command substitution,
and is supported by POSIX. However, all but the simplest uses become
complicated quickly. In particular, embedded command substitutions
and/or the use of double quotes require careful escaping with the backs=
lash
character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea=
ture from
the Korn shell.

The patch was generated by the simple script

for _f in $(find . -name "*.sh")
do
=C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 t/t3030-merge-recursive.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t3030-merge-recursive.sh b/t/t3030-merge-recursive.sh
index 82e1854..e9757c4 100755
--- a/t/t3030-merge-recursive.sh
+++ b/t/t3030-merge-recursive.sh
@@ -263,7 +263,7 @@ test_expect_success 'setup 8' '
 	test_ln_s_add e a &&
 	test_tick &&
 	git commit -m "rename a->e, symlink a->e" &&
-	oln=3D`printf e | git hash-object --stdin`
+	oln=3D$(printf e | git hash-object --stdin)
 '
=20
 test_expect_success 'setup 9' '
--=20
1.7.10.4