From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH v2 030/142] t3100-ls-tree-restrict.sh: use the $( ... ) construct for command substitution Date: Tue, 25 Mar 2014 10:22:51 -0700 Message-ID: <1395768283-31135-31-git-send-email-gitter.spiros@gmail.com> References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Mar 25 18:33:52 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WSVE8-0004n1-24 for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:33:28 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755597AbaCYRcl convert rfc822-to-quoted-printable (ORCPT ); Tue, 25 Mar 2014 13:32:41 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:50365 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755351AbaCYRZY (ORCPT ); Tue, 25 Mar 2014 13:25:24 -0400 Received: by mail-pd0-f176.google.com with SMTP id r10so717673pdi.21 for ; Tue, 25 Mar 2014 10:25:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=/+SK98LDxlGG0ZRP4Pd8V7jrcAbzCa25Fr+baD5GtnE=; b=a0koF5zjmwZ24+muznsClg3fnH+SaA5UvgenT6G1QGMtd5d20sYy7vZHDrUw0I8SRH IIwKfSz6KH2hccIhBq2wxknImNtyjRVw5oTJraCv5AVA4qFHmGZSyoPtpn8buT74Lsto LVJ1zHou+AxLuuki8/TbVjYKXufv6oPDIzW2l6YiFKmzi3L2WvXyRph/SoPgdjpn+2a5 /e3n48PwC37raeO757ZFl7h+Kc45BrUBjI/P3tyALzYsUGvpDlsgIDvcjyysm5+ulPrx 8IwYEwQ3/KRmr9M+VYcX8lZNbdxIJjaRRf4tRCNIKf3guzpDphfoLHXemrmIzPCdpuo5 XRrQ== X-Received: by 10.66.217.133 with SMTP id oy5mr81442299pac.46.1395768324209; Tue, 25 Mar 2014 10:25:24 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.25.23 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Mar 2014 10:25:23 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backs= lash character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea= ture from the Korn shell. The patch was generated by the simple script for _f in $(find . -name "*.sh") do =C2=A0 sed -i 's@`$.*$`@$(\1)@g' ${_f} done Signed-off-by: Elia Pinto --- t/t3100-ls-tree-restrict.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t3100-ls-tree-restrict.sh b/t/t3100-ls-tree-restrict.sh index eb73c06..325114f 100755 --- a/t/t3100-ls-tree-restrict.sh +++ b/t/t3100-ls-tree-restrict.sh @@ -28,7 +28,7 @@ test_expect_success \ echo Mi >path2/baz/b && find path? $ -type f -o -type l $ -print | xargs git update-index --add && - tree=3D`git write-tree` && + tree=3D$(git write-tree) && echo $tree' =20 test_output () { --=20 1.7.10.4