From mboxrd@z Thu Jan  1 00:00:00 1970
From: Elia Pinto <gitter.spiros@gmail.com>
Subject: [PATCH v2 037/142] t3905-stash-include-untracked.sh: use the $( ... ) construct for command substitution
Date: Tue, 25 Mar 2014 10:22:58 -0700
Message-ID: <1395768283-31135-38-git-send-email-gitter.spiros@gmail.com>
References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Elia Pinto <gitter.spiros@gmail.com>
To: git@vger.kernel.org
X-From: git-owner@vger.kernel.org Tue Mar 25 18:33:44 2014
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@plane.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1WSVE5-0004n1-Cx
	for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:33:25 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755576AbaCYRcJ convert rfc822-to-quoted-printable (ORCPT
	<rfc822;gcvg-git-2@m.gmane.org>); Tue, 25 Mar 2014 13:32:09 -0400
Received: from mail-pb0-f44.google.com ([209.85.160.44]:46211 "EHLO
	mail-pb0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932124AbaCYRZc (ORCPT <rfc822;git@vger.kernel.org>);
	Tue, 25 Mar 2014 13:25:32 -0400
Received: by mail-pb0-f44.google.com with SMTP id rp16so742145pbb.31
        for <git@vger.kernel.org>; Tue, 25 Mar 2014 10:25:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-type:content-transfer-encoding;
        bh=HS5iC54h1tFAGTh2RtSOdBz3IeSg7oHfEHXJSP0YAck=;
        b=jfNIdz2lSU5ZfU3Q+RXH91Xi9hanGR7I1TWrNs+YuUYdeWHfC3kzGdB/ypO3e0bKAR
         uPlcEV+TtVG7BnfgTvLzfGCa/rg8BCdsAFWdHtHuHmv3gCFiBkJFmEJax+vQu0ccFJgz
         AU+nsxAPrx9k1laouAji4YqqDfJ5JJXXRy2bJiU0E1Tzc8w7w0vocGxPqhJsBVn2BLk/
         li8eeG0Oqd0T1g8qvbKwTta7gJgBgNk9yitBjVZ6YXF4VDed3alH6F/ZlvYMZWnjFxxu
         Y+RBru0denEZxiER9EhBO7FQTAf45dDN8wM9owF8Meg+2PpytUBMvAix8GISdTwZ3L1B
         Uu0A==
X-Received: by 10.68.139.2 with SMTP id qu2mr11163551pbb.164.1395768331912;
        Tue, 25 Mar 2014 10:25:31 -0700 (PDT)
Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140])
        by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.25.30
        for <multiple recipients>
        (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
        Tue, 25 Mar 2014 10:25:31 -0700 (PDT)
X-Mailer: git-send-email 1.7.10.4
In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/245127>

The Git CodingGuidelines prefer the $( ... ) construct for command
substitution instead of using the back-quotes, or grave accents (`..`).

The backquoted form is the historical method for command substitution,
and is supported by POSIX. However, all but the simplest uses become
complicated quickly. In particular, embedded command substitutions
and/or the use of double quotes require careful escaping with the backs=
lash
character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea=
ture from
the Korn shell.

The patch was generated by the simple script

for _f in $(find . -name "*.sh")
do
=C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 t/t3905-stash-include-untracked.sh |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/t3905-stash-include-untracked.sh b/t/t3905-stash-include=
-untracked.sh
index a5e7e6b..f372fc8 100755
--- a/t/t3905-stash-include-untracked.sh
+++ b/t/t3905-stash-include-untracked.sh
@@ -96,8 +96,8 @@ test_expect_success 'stash pop after save --include-u=
ntracked leaves files untra
 	git stash pop &&
 	git status --porcelain >actual &&
 	test_cmp expect actual &&
-	test "1" =3D "`cat file2`" &&
-	test untracked =3D "`cat untracked/untracked`"
+	test "1" =3D "$(cat file2)" &&
+	test untracked =3D "$(cat untracked/untracked)"
 '
=20
 git clean --force --quiet -d
--=20
1.7.10.4