From mboxrd@z Thu Jan  1 00:00:00 1970
From: Elia Pinto <gitter.spiros@gmail.com>
Subject: [PATCH v2 045/142] t4038-diff-combined.sh: use the $( ... ) construct for command substitution
Date: Tue, 25 Mar 2014 10:23:06 -0700
Message-ID: <1395768283-31135-46-git-send-email-gitter.spiros@gmail.com>
References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Elia Pinto <gitter.spiros@gmail.com>
To: git@vger.kernel.org
X-From: git-owner@vger.kernel.org Tue Mar 25 18:32:51 2014
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@plane.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1WSVDT-0004n1-8Q
	for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:32:47 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755370AbaCYRZr convert rfc822-to-quoted-printable (ORCPT
	<rfc822;gcvg-git-2@m.gmane.org>); Tue, 25 Mar 2014 13:25:47 -0400
Received: from mail-pa0-f51.google.com ([209.85.220.51]:57615 "EHLO
	mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754688AbaCYRZm (ORCPT <rfc822;git@vger.kernel.org>);
	Tue, 25 Mar 2014 13:25:42 -0400
Received: by mail-pa0-f51.google.com with SMTP id kq14so749741pab.10
        for <git@vger.kernel.org>; Tue, 25 Mar 2014 10:25:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-type:content-transfer-encoding;
        bh=HlEIgukYCLKUt6VmcwKrmgSMJorTmiTGlMb4VmhB79Q=;
        b=HiaSi6dnmcEvdTAoRKomkjfPGTZWt24H1OOT6EpuQdPabXQgyynB3Hh4P3ga4z3F82
         Kq1xDurItQJPbjF2+L8MNj8H9l80YTnI35AFWC0ozQQIQlqdv79fGfIFjWo0tVBUfGWI
         tWRNXqHhH9B4x/hx9J+1kldHgYrPpdFnddoQO/sAVjLq/siNlI6Y3EQeCnqzCqmxJT/b
         ayTydBfsuZStN9mrv1XxajbxrWE80OptNgImgdGyYynFxf8HW8RACHJ75D9PlMg+g9QJ
         3Vd75lECSxqjMqUCM8zMtofAPmf60SNBdSExoP3j140QeJ0sRLu4CYEWusEP2WbJJesJ
         6U5Q==
X-Received: by 10.66.25.7 with SMTP id y7mr11779095paf.151.1395768341851;
        Tue, 25 Mar 2014 10:25:41 -0700 (PDT)
Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140])
        by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.25.40
        for <multiple recipients>
        (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
        Tue, 25 Mar 2014 10:25:41 -0700 (PDT)
X-Mailer: git-send-email 1.7.10.4
In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/245068>

The Git CodingGuidelines prefer the $( ... ) construct for command
substitution instead of using the back-quotes, or grave accents (`..`).

The backquoted form is the historical method for command substitution,
and is supported by POSIX. However, all but the simplest uses become
complicated quickly. In particular, embedded command substitutions
and/or the use of double quotes require careful escaping with the backs=
lash
character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea=
ture from
the Korn shell.

The patch was generated by the simple script

for _f in $(find . -name "*.sh")
do
=C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 t/t4038-diff-combined.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t4038-diff-combined.sh b/t/t4038-diff-combined.sh
index 1019d7b..41913c3 100755
--- a/t/t4038-diff-combined.sh
+++ b/t/t4038-diff-combined.sh
@@ -94,7 +94,7 @@ test_expect_success 'setup for --cc --raw' '
 	blob=3D$(echo file | git hash-object --stdin -w) &&
 	base_tree=3D$(echo "100644 blob $blob	file" | git mktree) &&
 	trees=3D &&
-	for i in `test_seq 1 40`
+	for i in $(test_seq 1 40)
 	do
 		blob=3D$(echo file$i | git hash-object --stdin -w) &&
 		trees=3D"$trees$(echo "100644 blob $blob	file" | git mktree)$LF"
--=20
1.7.10.4