From mboxrd@z Thu Jan  1 00:00:00 1970
From: Elia Pinto <gitter.spiros@gmail.com>
Subject: [PATCH v2 056/142] t5303-pack-corruption-resilience.sh: use the $( ... ) construct for command substitution
Date: Tue, 25 Mar 2014 10:23:17 -0700
Message-ID: <1395768283-31135-57-git-send-email-gitter.spiros@gmail.com>
References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Elia Pinto <gitter.spiros@gmail.com>
To: git@vger.kernel.org
X-From: git-owner@vger.kernel.org Tue Mar 25 18:32:55 2014
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@plane.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1WSVDW-0004n1-TS
	for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:32:51 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755385AbaCYRZz convert rfc822-to-quoted-printable (ORCPT
	<rfc822;gcvg-git-2@m.gmane.org>); Tue, 25 Mar 2014 13:25:55 -0400
Received: from mail-pa0-f47.google.com ([209.85.220.47]:37639 "EHLO
	mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754148AbaCYRZy (ORCPT <rfc822;git@vger.kernel.org>);
	Tue, 25 Mar 2014 13:25:54 -0400
Received: by mail-pa0-f47.google.com with SMTP id lj1so741154pab.20
        for <git@vger.kernel.org>; Tue, 25 Mar 2014 10:25:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-type:content-transfer-encoding;
        bh=NqZBbKgXmK4M0TJjfqlZ9+igyr3HCmZpvGRrQAs2if8=;
        b=qngD9S6PRzhyV2Hu7ruPgsjDOhDpJiSFSdDoq+cGTGHTr2WnNkHItHIi1rcl/a+Iz8
         TBNGMqLQom/Iq4vjtKYvIpMdvEI2lova3I7lAlWzov6wCTUjTPwkRQpDtFmOy8z6X6Ts
         AX6U/QWSutg1LMAREPlb9W0UFwadamYvloCVq8r977CCOM5ygPLYnYf+orKMdQEA/X0N
         REQtglAxILx2/q5mdAaU93a8I9mNKoqGdWCwR/gFdfB2aGPzuHrGQPr8XuKXfbbz/Ffr
         f+lafAI0tVY/a+cKHdmWGR+KLyJS2s5n80aPJksR0X64fzAm0kBRW0ZzI7+HJGiTmmBS
         U5PA==
X-Received: by 10.67.5.7 with SMTP id ci7mr78996390pad.99.1395768353731;
        Tue, 25 Mar 2014 10:25:53 -0700 (PDT)
Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140])
        by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.25.52
        for <multiple recipients>
        (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
        Tue, 25 Mar 2014 10:25:53 -0700 (PDT)
X-Mailer: git-send-email 1.7.10.4
In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/245072>

The Git CodingGuidelines prefer the $( ... ) construct for command
substitution instead of using the back-quotes, or grave accents (`..`).

The backquoted form is the historical method for command substitution,
and is supported by POSIX. However, all but the simplest uses become
complicated quickly. In particular, embedded command substitutions
and/or the use of double quotes require careful escaping with the backs=
lash
character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea=
ture from
the Korn shell.

The patch was generated by the simple script

for _f in $(find . -name "*.sh")
do
=C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 t/t5303-pack-corruption-resilience.sh |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/t/t5303-pack-corruption-resilience.sh b/t/t5303-pack-corru=
ption-resilience.sh
index 663b02b..98bed18 100755
--- a/t/t5303-pack-corruption-resilience.sh
+++ b/t/t5303-pack-corruption-resilience.sh
@@ -32,9 +32,9 @@ create_test_files() {
 create_new_pack() {
     rm -rf .git &&
     git init &&
-    blob_1=3D`git hash-object -t blob -w file_1` &&
-    blob_2=3D`git hash-object -t blob -w file_2` &&
-    blob_3=3D`git hash-object -t blob -w file_3` &&
+    blob_1=3D$(git hash-object -t blob -w file_1) &&
+    blob_2=3D$(git hash-object -t blob -w file_2) &&
+    blob_3=3D$(git hash-object -t blob -w file_3) &&
     pack=3D`printf "$blob_1\n$blob_2\n$blob_3\n" |
           git pack-objects $@ .git/objects/pack/pack` &&
     pack=3D".git/objects/pack/pack-${pack}" &&
@@ -48,7 +48,7 @@ do_repack() {
 }
=20
 do_corrupt_object() {
-    ofs=3D`git show-index < ${pack}.idx | grep $1 | cut -f1 -d" "` &&
+    ofs=3D$(git show-index < ${pack}.idx | grep $1 | cut -f1 -d" ") &&
     ofs=3D$(($ofs + $2)) &&
     chmod +w ${pack}.pack &&
     dd of=3D${pack}.pack bs=3D1 conv=3Dnotrunc seek=3D$ofs &&
--=20
1.7.10.4