From mboxrd@z Thu Jan  1 00:00:00 1970
From: Elia Pinto <gitter.spiros@gmail.com>
Subject: [PATCH v2 062/142] t5510-fetch.sh: use the $( ... ) construct for command substitution
Date: Tue, 25 Mar 2014 10:23:23 -0700
Message-ID: <1395768283-31135-63-git-send-email-gitter.spiros@gmail.com>
References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Elia Pinto <gitter.spiros@gmail.com>
To: git@vger.kernel.org
X-From: git-owner@vger.kernel.org Tue Mar 25 18:33:32 2014
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@plane.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1WSVDx-0004n1-MQ
	for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:33:18 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755235AbaCYRaS convert rfc822-to-quoted-printable (ORCPT
	<rfc822;gcvg-git-2@m.gmane.org>); Tue, 25 Mar 2014 13:30:18 -0400
Received: from mail-pb0-f43.google.com ([209.85.160.43]:54670 "EHLO
	mail-pb0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755386AbaCYR0A (ORCPT <rfc822;git@vger.kernel.org>);
	Tue, 25 Mar 2014 13:26:00 -0400
Received: by mail-pb0-f43.google.com with SMTP id um1so742740pbc.16
        for <git@vger.kernel.org>; Tue, 25 Mar 2014 10:26:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-type:content-transfer-encoding;
        bh=Br6OjnmvV8xQekfWuRk67PMMr1DHdaxPEQCxN7fG6aY=;
        b=nrBMKUTwETpBnd+f0YxRqNP/xE2s908MimoO+xb+ryXG0I6/UrueOBvoG8liCT3usp
         61jFqxy4i1EkmyFPUlH1j1ZYEvJLDgc2vatGpudlvJf3m03A/b5+VQ/jk512ukOKuEPX
         /25ukzjmyPsRP+AjYVDBz9PfAylu7L7kbkuDeCfLpwEnwzuoDUxycpY2yvOIk12isjp/
         0QqBq9p7/8gZNe9vgL3g2JqtCix6cQHE4pnlv/Systs7zdmK4xCReNSzPInDWYUr6cev
         02XdblKQnCkhYTvBD10f9UTKU0jfaVOUWprnIn7RwCe2FLVWr/dbi4KjyehCr3E+ah7W
         zcug==
X-Received: by 10.66.25.7 with SMTP id y7mr11780755paf.151.1395768360028;
        Tue, 25 Mar 2014 10:26:00 -0700 (PDT)
Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140])
        by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.25.59
        for <multiple recipients>
        (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
        Tue, 25 Mar 2014 10:25:59 -0700 (PDT)
X-Mailer: git-send-email 1.7.10.4
In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/245109>

The Git CodingGuidelines prefer the $( ... ) construct for command
substitution instead of using the back-quotes, or grave accents (`..`).

The backquoted form is the historical method for command substitution,
and is supported by POSIX. However, all but the simplest uses become
complicated quickly. In particular, embedded command substitutions
and/or the use of double quotes require careful escaping with the backs=
lash
character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea=
ture from
the Korn shell.

The patch was generated by the simple script

for _f in $(find . -name "*.sh")
do
=C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 t/t5510-fetch.sh |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh
index ab28594..31b185e 100755
--- a/t/t5510-fetch.sh
+++ b/t/t5510-fetch.sh
@@ -7,7 +7,7 @@ test_description=3D'Per branch config variables affects=
 "git fetch".
=20
 . ./test-lib.sh
=20
-D=3D`pwd`
+D=3D$(pwd)
=20
 test_bundle_object_count () {
 	git verify-pack -v "$1" >verify.out &&
@@ -64,8 +64,8 @@ test_expect_success "fetch test" '
 	cd two &&
 	git fetch &&
 	test -f .git/refs/heads/one &&
-	mine=3D`git rev-parse refs/heads/one` &&
-	his=3D`cd ../one && git rev-parse refs/heads/master` &&
+	mine=3D$(git rev-parse refs/heads/one) &&
+	his=3D$(cd ../one && git rev-parse refs/heads/master) &&
 	test "z$mine" =3D "z$his"
 '
=20
@@ -75,8 +75,8 @@ test_expect_success "fetch test for-merge" '
 	git fetch &&
 	test -f .git/refs/heads/two &&
 	test -f .git/refs/heads/one &&
-	master_in_two=3D`cd ../two && git rev-parse master` &&
-	one_in_two=3D`cd ../two && git rev-parse one` &&
+	master_in_two=3D$(cd ../two && git rev-parse master) &&
+	one_in_two=3D$(cd ../two && git rev-parse one) &&
 	{
 		echo "$one_in_two	"
 		echo "$master_in_two	not-for-merge"
--=20
1.7.10.4