From mboxrd@z Thu Jan  1 00:00:00 1970
From: Elia Pinto <gitter.spiros@gmail.com>
Subject: [PATCH v2 068/142] t5530-upload-pack-error.sh: use the $( ... ) construct for command substitution
Date: Tue, 25 Mar 2014 10:23:29 -0700
Message-ID: <1395768283-31135-69-git-send-email-gitter.spiros@gmail.com>
References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Elia Pinto <gitter.spiros@gmail.com>
To: git@vger.kernel.org
X-From: git-owner@vger.kernel.org Tue Mar 25 18:33:02 2014
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@plane.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1WSVDb-0004n1-7D
	for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:32:55 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932145AbaCYR0O convert rfc822-to-quoted-printable (ORCPT
	<rfc822;gcvg-git-2@m.gmane.org>); Tue, 25 Mar 2014 13:26:14 -0400
Received: from mail-pa0-f50.google.com ([209.85.220.50]:44785 "EHLO
	mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755400AbaCYR0G (ORCPT <rfc822;git@vger.kernel.org>);
	Tue, 25 Mar 2014 13:26:06 -0400
Received: by mail-pa0-f50.google.com with SMTP id kq14so742794pab.9
        for <git@vger.kernel.org>; Tue, 25 Mar 2014 10:26:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-type:content-transfer-encoding;
        bh=xCD3pXxiOpO/X0PAM3uo1omDtZ6MrO42c+WIWymIPLs=;
        b=jUvYwp18dwPW5SfqsPtXgFncTr1IwCr8iH0CBUKIVFytmZ4KY4SHjQ8Tv0UEA8uaov
         VeYzSImFup9fLz/8zgrVFx1G7u2rPb2zTm9g0PYuDZxqe7/WUGylENg70ps9OZJNJjBy
         1LXCxFsEH31gC1uTEBry74156PU4TARlvoHxhNclpaccZRCwJVzL6EWcw76J6hEfiCGG
         E+p0kPn1ucuNh0anfMu5M69/KfcwBoDJ513Em6UKykZJh/dQOJp1Iku88tr9Sp9mPJFN
         Ow1Lj0eEwQtlaeg6LTqWxvE47xxDgI2Kwlc/6ZhZ1bkDVlQGKjzWaZpGFcuolnGIVcKo
         28jQ==
X-Received: by 10.68.239.70 with SMTP id vq6mr12100218pbc.152.1395768366358;
        Tue, 25 Mar 2014 10:26:06 -0700 (PDT)
Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140])
        by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.26.05
        for <multiple recipients>
        (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
        Tue, 25 Mar 2014 10:26:05 -0700 (PDT)
X-Mailer: git-send-email 1.7.10.4
In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/245082>

The Git CodingGuidelines prefer the $( ... ) construct for command
substitution instead of using the back-quotes, or grave accents (`..`).

The backquoted form is the historical method for command substitution,
and is supported by POSIX. However, all but the simplest uses become
complicated quickly. In particular, embedded command substitutions
and/or the use of double quotes require careful escaping with the backs=
lash
character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea=
ture from
the Korn shell.

The patch was generated by the simple script

for _f in $(find . -name "*.sh")
do
=C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 t/t5530-upload-pack-error.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t5530-upload-pack-error.sh b/t/t5530-upload-pack-error.s=
h
index 3932e79..4f6e32b 100755
--- a/t/t5530-upload-pack-error.sh
+++ b/t/t5530-upload-pack-error.sh
@@ -4,7 +4,7 @@ test_description=3D'errors in upload-pack'
=20
 . ./test-lib.sh
=20
-D=3D`pwd`
+D=3D$(pwd)
=20
 corrupt_repo () {
 	object_sha1=3D$(git rev-parse "$1") &&
--=20
1.7.10.4