From mboxrd@z Thu Jan  1 00:00:00 1970
From: Elia Pinto <gitter.spiros@gmail.com>
Subject: [PATCH v2 006/142] git-stash.sh: use the $( ... ) construct for command substitution
Date: Tue, 25 Mar 2014 10:22:27 -0700
Message-ID: <1395768283-31135-7-git-send-email-gitter.spiros@gmail.com>
References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Elia Pinto <gitter.spiros@gmail.com>
To: git@vger.kernel.org
X-From: git-owner@vger.kernel.org Tue Mar 25 18:25:24 2014
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@plane.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1WSV6I-0005m3-Rj
	for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:25:23 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755308AbaCYRY4 convert rfc822-to-quoted-printable (ORCPT
	<rfc822;gcvg-git-2@m.gmane.org>); Tue, 25 Mar 2014 13:24:56 -0400
Received: from mail-pd0-f180.google.com ([209.85.192.180]:61287 "EHLO
	mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755183AbaCYRYz (ORCPT <rfc822;git@vger.kernel.org>);
	Tue, 25 Mar 2014 13:24:55 -0400
Received: by mail-pd0-f180.google.com with SMTP id v10so716113pde.25
        for <git@vger.kernel.org>; Tue, 25 Mar 2014 10:24:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-type:content-transfer-encoding;
        bh=cj/wwhIMR5JKKF6qWbHwX4S5DRr3XTCG0g1uAtvTAn8=;
        b=zVMGqofafmS60MT7h5oqi/E86iqyfxYDdFOlVPTIgMU72+29WS33H1rDLbX/jnDcm/
         ZjItgyjsaGr+J/fj2OZta/MKI//nwDBbXgZBGru6GiYi+irxoQLOpwXYKw0/fd6sDMs9
         /NaGbzyKjx8QXOkh3NBbUW97oygKFmBND9wogfayhFitd5umw7WTDCGH0ChRsMQfXwlE
         r3dr24V0zf90Dzg1RQVQzia7zdtG6T4P7JaEuhQUaCYFNFBhxQn/QUynVmLLAbcIG0V3
         OF8R0L8Ah4PYO1Uh5dtkZUKy+JF92xSyKltr9q0bL0g/4AZQnSaZHHBDJhu0PcsRmGa6
         bH3w==
X-Received: by 10.66.232.68 with SMTP id tm4mr79625567pac.114.1395768294461;
        Tue, 25 Mar 2014 10:24:54 -0700 (PDT)
Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140])
        by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.24.53
        for <multiple recipients>
        (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
        Tue, 25 Mar 2014 10:24:53 -0700 (PDT)
X-Mailer: git-send-email 1.7.10.4
In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/245051>

The Git CodingGuidelines prefer the $( ... ) construct for command
substitution instead of using the back-quotes, or grave accents (`..`).

The backquoted form is the historical method for command substitution,
and is supported by POSIX. However, all but the simplest uses become
complicated quickly. In particular, embedded command substitutions
and/or the use of double quotes require careful escaping with the backs=
lash
character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea=
ture from
the Korn shell.

The patch was generated by the simple script

for _f in $(find . -name "*.sh")
do
=C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 git-stash.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/git-stash.sh b/git-stash.sh
index 4798bcf..af549c7 100755
--- a/git-stash.sh
+++ b/git-stash.sh
@@ -13,7 +13,7 @@ USAGE=3D"list [<options>]
=20
 SUBDIRECTORY_OK=3DYes
 OPTIONS_SPEC=3D
-START_DIR=3D`pwd`
+START_DIR=3D$(pwd)
 . git-sh-setup
 . git-sh-i18n
 require_work_tree
--=20
1.7.10.4