From mboxrd@z Thu Jan  1 00:00:00 1970
From: Elia Pinto <gitter.spiros@gmail.com>
Subject: [PATCH v2 070/142] t5538-push-shallow.sh: use the $( ... ) construct for command substitution
Date: Tue, 25 Mar 2014 10:23:31 -0700
Message-ID: <1395768283-31135-71-git-send-email-gitter.spiros@gmail.com>
References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Elia Pinto <gitter.spiros@gmail.com>
To: git@vger.kernel.org
X-From: git-owner@vger.kernel.org Tue Mar 25 18:33:01 2014
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@plane.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1WSVDa-0004n1-1k
	for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:32:54 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755422AbaCYR0M convert rfc822-to-quoted-printable (ORCPT
	<rfc822;gcvg-git-2@m.gmane.org>); Tue, 25 Mar 2014 13:26:12 -0400
Received: from mail-pb0-f41.google.com ([209.85.160.41]:48715 "EHLO
	mail-pb0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755410AbaCYR0I (ORCPT <rfc822;git@vger.kernel.org>);
	Tue, 25 Mar 2014 13:26:08 -0400
Received: by mail-pb0-f41.google.com with SMTP id jt11so754944pbb.0
        for <git@vger.kernel.org>; Tue, 25 Mar 2014 10:26:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-type:content-transfer-encoding;
        bh=uOvs2zaJNYK4KdPWCpAicLpOmD4UDwC6x/mTPNUkkkg=;
        b=DoJ4uoc3MPx/GduHPaTyphWpi8MaBEyvolDZwPEermTPwADFv2TEMl4/vvVxR1HlH3
         T5dzUrcuAqbEvch63KMrFxe6oJsKP92Hlm6vQTT3/Osw717+fzMjk0dRh+zWzotYBNYg
         8k35ZdqdCo0+b8cvNjxN/25e1zI0RrLCNy3M53NvJZTiTcGtN2+lXxbtVrn3Bf5GAtvy
         JK2BvTrT5riY3XLAACKs8ZPpvpu2oZ14WWQ/T246BGMNuKU5fQ+CIAO5MpGoBetncS/4
         Y1EiZpxBisHkQAyTwZk8sPHLXoj0n9M5V1RlNQILvyNEUiHB7j6XjHx2TW1+LIVeKk5a
         /z3w==
X-Received: by 10.68.201.226 with SMTP id kd2mr12167434pbc.157.1395768368196;
        Tue, 25 Mar 2014 10:26:08 -0700 (PDT)
Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140])
        by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.26.07
        for <multiple recipients>
        (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
        Tue, 25 Mar 2014 10:26:07 -0700 (PDT)
X-Mailer: git-send-email 1.7.10.4
In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/245078>

The Git CodingGuidelines prefer the $( ... ) construct for command
substitution instead of using the back-quotes, or grave accents (`..`).

The backquoted form is the historical method for command substitution,
and is supported by POSIX. However, all but the simplest uses become
complicated quickly. In particular, embedded command substitutions
and/or the use of double quotes require careful escaping with the backs=
lash
character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea=
ture from
the Korn shell.

The patch was generated by the simple script

for _f in $(find . -name "*.sh")
do
=C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 t/t5538-push-shallow.sh |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/t5538-push-shallow.sh b/t/t5538-push-shallow.sh
index 8e54ac5..23a729a 100755
--- a/t/t5538-push-shallow.sh
+++ b/t/t5538-push-shallow.sh
@@ -104,7 +104,7 @@ EOF
 '
=20
 test_expect_success 'push from full to shallow' '
-	! git --git-dir=3Dshallow2/.git cat-file blob `echo 1|git hash-object=
 --stdin` &&
+	! git --git-dir=3Dshallow2/.git cat-file blob $(echo 1|git hash-objec=
t --stdin) &&
 	commit 1 &&
 	git push shallow2/.git +master:refs/remotes/top/master &&
 	(
@@ -117,7 +117,7 @@ test_expect_success 'push from full to shallow' '
 3
 EOF
 	test_cmp expect actual &&
-	git cat-file blob `echo 1|git hash-object --stdin` >/dev/null
+	git cat-file blob $(echo 1|git hash-object --stdin) >/dev/null
 	)
 '
=20
--=20
1.7.10.4