From mboxrd@z Thu Jan  1 00:00:00 1970
From: Elia Pinto <gitter.spiros@gmail.com>
Subject: [PATCH v2 089/142] t7406-submodule-update.sh: use the $( ... ) construct for command substitution
Date: Tue, 25 Mar 2014 10:23:50 -0700
Message-ID: <1395768283-31135-90-git-send-email-gitter.spiros@gmail.com>
References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Elia Pinto <gitter.spiros@gmail.com>
To: git@vger.kernel.org
X-From: git-owner@vger.kernel.org Tue Mar 25 18:33:08 2014
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@plane.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1WSVDg-0004n1-K9
	for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:33:00 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932152AbaCYR0g convert rfc822-to-quoted-printable (ORCPT
	<rfc822;gcvg-git-2@m.gmane.org>); Tue, 25 Mar 2014 13:26:36 -0400
Received: from mail-pd0-f174.google.com ([209.85.192.174]:55115 "EHLO
	mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755427AbaCYR0b (ORCPT <rfc822;git@vger.kernel.org>);
	Tue, 25 Mar 2014 13:26:31 -0400
Received: by mail-pd0-f174.google.com with SMTP id y13so714647pdi.5
        for <git@vger.kernel.org>; Tue, 25 Mar 2014 10:26:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-type:content-transfer-encoding;
        bh=2ownRlwKBmH5bkN6EGy8XpOfbmT55vIApGC0MQvJivk=;
        b=tOpiZUFGL7oruZWZJjfMCMkix+4z2BK8p/XOvPkIrrCSmf05saEnEQDnb0pJrOV9CQ
         /lofsUIxxNsxYC5pylcZw3aJoQsCxYaTfhATZ77HZCsAxikKgEPy9arAzMKYdF7oSpUZ
         tbb17Q5FzuvwkAFIfHYUbuI9QtSZIfUBaO9RkBri1URHwrV85SgV5fko6dFGG+l63/QP
         zlSwQ1IeOnlKcNgTsr0jZ7Zpw6br6b0ScJr8IpxTzv727GetVZ2/Hh+ghBsKA61hN8uw
         b1SEXdg2YmCYivuRBCAcPlemwMy7TAh8KbTt5C0/iohAJIEiYf9YBEWuoUOvij++Eg2v
         Vl/w==
X-Received: by 10.66.122.101 with SMTP id lr5mr17556245pab.130.1395768390640;
        Tue, 25 Mar 2014 10:26:30 -0700 (PDT)
Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140])
        by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.26.29
        for <multiple recipients>
        (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
        Tue, 25 Mar 2014 10:26:30 -0700 (PDT)
X-Mailer: git-send-email 1.7.10.4
In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/245090>

The Git CodingGuidelines prefer the $( ... ) construct for command
substitution instead of using the back-quotes, or grave accents (`..`).

The backquoted form is the historical method for command substitution,
and is supported by POSIX. However, all but the simplest uses become
complicated quickly. In particular, embedded command substitutions
and/or the use of double quotes require careful escaping with the backs=
lash
character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea=
ture from
the Korn shell.

The patch was generated by the simple script

for _f in $(find . -name "*.sh")
do
=C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 t/t7406-submodule-update.sh |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh
index 28ca763..294a4a6 100755
--- a/t/t7406-submodule-update.sh
+++ b/t/t7406-submodule-update.sh
@@ -14,8 +14,8 @@ submodule and "git submodule update --rebase/--merge"=
 does not detach the HEAD.
=20
 compare_head()
 {
-    sha_master=3D`git rev-list --max-count=3D1 master`
-    sha_head=3D`git rev-list --max-count=3D1 HEAD`
+    sha_master=3D$(git rev-list --max-count=3D1 master)
+    sha_head=3D$(git rev-list --max-count=3D1 HEAD)
=20
     test "$sha_master" =3D "$sha_head"
 }
--=20
1.7.10.4