From: Elia Pinto <gitter.spiros@gmail.com>
To: git@vger.kernel.org
Cc: matthieu.moy@grenoble-inp.fr, Elia Pinto <gitter.spiros@gmail.com>
Subject: [PATCH 08/14] t4036-format-patch-signer-mime.sh: use the $( ... ) construct for command substitution
Date: Wed, 30 Apr 2014 09:23:01 -0700 [thread overview]
Message-ID: <1398874987-14873-8-git-send-email-gitter.spiros@gmail.com> (raw)
In-Reply-To: <1398874987-14873-1-git-send-email-gitter.spiros@gmail.com>
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
t/t4036-format-patch-signer-mime.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t4036-format-patch-signer-mime.sh b/t/t4036-format-patch-signer-mime.sh
index ba43f18..98d9713 100755
--- a/t/t4036-format-patch-signer-mime.sh
+++ b/t/t4036-format-patch-signer-mime.sh
@@ -42,7 +42,7 @@ test_expect_success 'attach and signoff do not duplicate mime headers' '
GIT_COMMITTER_NAME="はまの ふにおう" \
git format-patch -s --stdout -1 --attach >output &&
- test `grep -ci ^MIME-Version: output` = 1
+ test $(grep -ci ^MIME-Version: output) = 1
'
--
1.7.10.4
next prev parent reply other threads:[~2014-04-30 16:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 16:22 [PATCH 01/14] t3905-stash-include-untracked.sh: use the $( ... ) construct for command substitution Elia Pinto
2014-04-30 16:22 ` [PATCH 02/14] t3910-mac-os-precompose.sh: " Elia Pinto
2014-04-30 16:22 ` [PATCH 03/14] t4006-diff-mode.sh: " Elia Pinto
2014-04-30 16:22 ` [PATCH 04/14] t4010-diff-pathspec.sh: " Elia Pinto
2014-04-30 16:22 ` [PATCH 05/14] t4012-diff-binary.sh: " Elia Pinto
2014-04-30 16:22 ` [PATCH 06/14] t4013-diff-various.sh: " Elia Pinto
2014-04-30 16:23 ` [PATCH 07/14] t4014-format-patch.sh: " Elia Pinto
2014-04-30 16:23 ` Elia Pinto [this message]
2014-04-30 16:23 ` [PATCH 09/14] t4038-diff-combined.sh: " Elia Pinto
2014-04-30 16:23 ` [PATCH 10/14] t4057-diff-combined-paths.sh: " Elia Pinto
2014-04-30 16:23 ` [PATCH 11/14] t4116-apply-reverse.sh: " Elia Pinto
2014-04-30 16:23 ` [PATCH 12/14] t4119-apply-config.sh: " Elia Pinto
2014-04-30 16:23 ` [PATCH 13/14] t4204-patch-id.sh: " Elia Pinto
2014-04-30 16:23 ` [PATCH 14/14] t5000-tar-tree.sh: " Elia Pinto
2014-04-30 16:42 ` [PATCH 01/14] t3905-stash-include-untracked.sh: " Matthieu Moy
2014-04-30 18:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398874987-14873-8-git-send-email-gitter.spiros@gmail.com \
--to=gitter.spiros@gmail.com \
--cc=git@vger.kernel.org \
--cc=matthieu.moy@grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).