git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Packham <judge.packham@gmail.com>
To: git@vger.kernel.org
Cc: Chris Packham <judge.packham@gmail.com>
Subject: [RFC PATCHv2 0/2] am: bug fix and new patch format support
Date: Thu,  4 Sep 2014 10:21:56 +1200	[thread overview]
Message-ID: <1409782918-26133-1-git-send-email-judge.packham@gmail.com> (raw)
In-Reply-To: <1409736919-22341-1-git-send-email-judge.packham@gmail.com>
In-Reply-To: <1409736919-22341-1-git-send-email-judge.packham@gmail.com>

I've done some digging into the tr error message. I think the extra
re-direction of stdin is unnecessary. I've removed it and the tests
still pass. The error message I was seeing is no longer seen but I've
found it hard to actually reproduce (even with different sized patches).

I've also updated 'am: avoid re-directing stdin twice' to add some tests
and only strip the description part of the patch.

Chris Packham (2):
  am: add gitk patch format
  am: avoid re-directing stdin twice

 Documentation/git-am.txt |  3 ++-
 git-am.sh                | 38 +++++++++++++++++++++++++++++++++++++-
 t/t4150-am.sh            | 13 +++++++++++++
 3 files changed, 52 insertions(+), 2 deletions(-)

-- 
2.0.4.2.gadd452d

  parent reply	other threads:[~2014-09-03 22:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-03  9:35 [RFC PATCH 0/1] am: bug report and new patch format support Chris Packham
2014-09-03  9:35 ` [RFC PATCH 1/1] am: add gitk patch format Chris Packham
2014-09-03  9:59   ` Chris Packham
2014-09-03 10:18 ` [RFC PATCH 0/1] am: bug report and new patch format support Chris Packham
2014-09-03 22:21 ` Chris Packham [this message]
2014-09-03 22:21   ` [RFC PATCHv2 1/2] am: add gitk patch format Chris Packham
2014-09-03 23:19     ` Junio C Hamano
2014-09-04  0:46       ` Chris Packham
2014-09-04 17:21         ` Junio C Hamano
2014-09-04 22:47           ` Chris Packham
     [not found]             ` <CAPc5daWip1dQ5Or6hzmdjoBUStusvs-jK0ODNuzAotNfM5BLbQ@mail.gmail.com>
2014-09-05  1:23               ` Chris Packham
2014-09-05 18:29                 ` Junio C Hamano
2014-09-05 21:54                   ` Chris Packham
2014-09-03 22:21   ` [RFC PATCHv2 2/2] am: avoid re-directing stdin twice Chris Packham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409782918-26133-1-git-send-email-judge.packham@gmail.com \
    --to=judge.packham@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).