From: David Turner <dturner@twopensource.com>
To: git@vger.kernel.org, pclouds@gmail.com, aevarb@gmail.com,
jeffhost@microsoft.com
Cc: David Turner <dturner@twopensource.com>
Subject: [PATCH v3 13/16] index-helper: don't run if already running
Date: Wed, 6 Apr 2016 18:11:59 -0400 [thread overview]
Message-ID: <1459980722-4836-14-git-send-email-dturner@twopensource.com> (raw)
In-Reply-To: <1459980722-4836-1-git-send-email-dturner@twopensource.com>
Signed-off-by: David Turner <dturner@twopensource.com>
---
index-helper.c | 7 +++++++
t/t7900-index-helper.sh | 9 +++++++++
2 files changed, 16 insertions(+)
diff --git a/index-helper.c b/index-helper.c
index a3f6a74..b62d805 100644
--- a/index-helper.c
+++ b/index-helper.c
@@ -413,6 +413,13 @@ int main(int argc, char **argv)
return 0;
}
+ /* check that no other copy is running */
+ fd = connect_to_index_helper();
+ if (fd > 0)
+ die(_("Already running"));
+ if (errno != ECONNREFUSED && errno != ENOENT)
+ die_errno(_("Unexpected error checking socket"));
+
atexit(cleanup);
sigchain_push_common(cleanup_on_signal);
diff --git a/t/t7900-index-helper.sh b/t/t7900-index-helper.sh
index b1fa96e..3f94d8a 100755
--- a/t/t7900-index-helper.sh
+++ b/t/t7900-index-helper.sh
@@ -33,4 +33,13 @@ test_expect_success 'index-helper creates usable path file and can be killed' '
test_path_is_missing .git/index-helper.path
'
+test_expect_success 'index-helper will not start if already running' '
+ test_when_finished "git index-helper --kill" &&
+ git index-helper --detach &&
+ test -L .git/index-helper.path &&
+ test_must_fail git index-helper 2>err &&
+ test -L .git/index-helper.path &&
+ grep "Already running" err
+'
+
test_done
--
2.4.2.767.g62658d5-twtrsrc
next prev parent reply other threads:[~2016-04-06 22:13 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 22:11 [PATCH v3 00/16] index-helper, watchman David Turner
2016-04-06 22:11 ` [PATCH v3 01/16] read-cache.c: fix constness of verify_hdr() David Turner
2016-04-06 22:11 ` [PATCH v3 02/16] read-cache: allow to keep mmap'd memory after reading David Turner
2016-04-06 22:11 ` [PATCH v3 03/16] index-helper: new daemon for caching index and related stuff David Turner
2016-04-07 6:21 ` Johannes Sixt
2016-04-07 14:14 ` Johannes Schindelin
2016-04-07 18:47 ` David Turner
2016-04-08 14:17 ` Johannes Schindelin
2016-04-08 11:26 ` Duy Nguyen
2016-04-08 22:16 ` David Turner
2016-04-11 23:27 ` David Turner
2016-04-12 9:40 ` Duy Nguyen
2016-04-12 17:28 ` David Turner
2016-04-12 18:05 ` Junio C Hamano
2016-04-13 0:32 ` David Turner
2016-04-14 10:43 ` Duy Nguyen
2016-04-14 18:12 ` Junio C Hamano
2016-04-14 18:20 ` David Turner
2016-04-15 0:16 ` Duy Nguyen
2016-04-15 1:31 ` Junio C Hamano
2016-04-06 22:11 ` [PATCH v3 04/16] index-helper: add --strict David Turner
2016-04-06 22:11 ` [PATCH v3 05/16] daemonize(): set a flag before exiting the main process David Turner
2016-04-06 22:11 ` [PATCH v3 06/16] index-helper: add --detach David Turner
2016-04-06 22:11 ` [PATCH v3 07/16] read-cache: add watchman 'WAMA' extension David Turner
2016-04-06 22:11 ` [PATCH v3 08/16] Add watchman support to reduce index refresh cost David Turner
2016-04-06 22:11 ` [PATCH v3 09/16] index-helper: use watchman to avoid refreshing index with lstat() David Turner
2016-04-07 22:47 ` Junio C Hamano
2016-04-07 22:52 ` Junio C Hamano
2016-04-08 0:14 ` David Turner
2016-04-08 6:03 ` Junio C Hamano
2016-04-06 22:11 ` [PATCH v3 10/16] update-index: enable/disable watchman support David Turner
2016-04-06 22:11 ` [PATCH v3 11/16] unpack-trees: preserve index extensions David Turner
2016-04-06 22:11 ` [PATCH v3 12/16] index-helper: kill mode David Turner
2016-04-06 22:11 ` David Turner [this message]
2016-04-06 22:12 ` [PATCH v3 14/16] index-helper: autorun mode David Turner
2016-04-06 22:12 ` [PATCH v3 15/16] index-helper: optionally automatically run David Turner
2016-04-06 22:12 ` [PATCH v3 16/16] read-cache: config for waiting for index-helper David Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459980722-4836-14-git-send-email-dturner@twopensource.com \
--to=dturner@twopensource.com \
--cc=aevarb@gmail.com \
--cc=git@vger.kernel.org \
--cc=jeffhost@microsoft.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).