From: Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [GSoC][PATCH v2] ref-filter: Make "--contains <id>" less chatty if <id> is invalid
Date: Sat, 24 Feb 2018 16:12:48 +0200 [thread overview]
Message-ID: <1519481568.32160.3.camel@gmail.com> (raw)
In-Reply-To: <xmqq371rs23z.fsf@gitster-ct.c.googlers.com>
Hello,
Your proposed solution makes a lot more sense. I have actually
considered a solution similar to this (the third solution from [1]),
but found it more complicated. I did not account for the fact that
once a callback is called, the user is already aware of the available
options and the user only supplied an invalid argument value.
I also have to make sure that all parsers (all callbacks and standard
ones, for integer, filename, etc.) are already printing errors
appropriately. Otherwise, some commands may fail and the user will not
be aware of it because nothing will be shown (no usage is shown and no
errors either).
I will be implementing this solution and come back with another patch.
Thank you for your review. I really appreciate it!
[1] https://public-inbox.org/git/20160118215433.GB24136@sigill.intra.pe
ff.net/
Best regards,
Paul Ungureanu
prev parent reply other threads:[~2018-02-24 14:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 16:25 [GSoC][PATCH v2] ref-filter: Make "--contains <id>" less chatty if <id> is invalid Paul-Sebastian Ungureanu
2018-02-23 20:58 ` Junio C Hamano
2018-02-23 23:44 ` Junio C Hamano
2018-02-24 14:12 ` Paul-Sebastian Ungureanu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519481568.32160.3.camel@gmail.com \
--to=ungureanupaulsebastian@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).