From: Heather Lapointe <alpha@alphaservcomputing.solutions>
To: "\"René Scharfe\"" <l.s.r@web.de>
Cc: "heather lapointe via gitgitgadget" <gitgitgadget@gmail.com>,
"git" <git@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] archive: Add --recurse-submodules to git-archive command
Date: Thu, 13 Oct 2022 14:23:11 -0700 [thread overview]
Message-ID: <183d33ad4dc.b3e5b5ca123845.2982022328880074553@alphaservcomputing.solutions> (raw)
In-Reply-To: <97a82675-22bb-b996-deac-3f13a91f3df4@web.de>
---- On Thu, 13 Oct 2022 10:53:44 -0700 René Scharfe wrote ---
> > I am open to feedback since this is all quite new to me :)
> >
> > TODO:
>
> This list confuses me:
I apologize. I'm new to this repo and workflow.
I had been using checkboxes in github, which look like `- [x]` for ones that I have completed.
They all got converted into items that look like they needed doing via GitGitGadget.
The only remaining one was to update documentation.
>
> >
> > Alphadelta14 (2):
> > archive: add --recurse-submodules to git-archive command
> > archive: fix a case of submodule in submodule traversal
>
> We prefer to keep known bugs out of the repo. It helps when bisecting,
> for example. So it would be better to squash the fix into the patch
> that adds the feature. But...
Absolutely can do.
>
> > archive-tar.c | 14 +++--
> > archive-zip.c | 14 ++---
> > archive.c | 99 ++++++++++++++++++++++++-----------
> > archive.h | 8 +--
> > builtin/checkout.c | 2 +-
> > builtin/log.c | 2 +-
> > builtin/ls-files.c | 10 ++--
> > builtin/ls-tree.c | 16 +++---
> > list-objects.c | 2 +-
> > merge-recursive.c | 2 +-
> > revision.c | 4 +-
> > sparse-index.c | 2 +-
> > t/t5005-archive-submodules.sh | 84 +++++++++++++++++++++++++++++
> > tree.c | 93 ++++++++++++++++++++++----------
> > tree.h | 11 ++--
> > wt-status.c | 2 +-
> > 16 files changed, 269 insertions(+), 96 deletions(-)
> > create mode 100755 t/t5005-archive-submodules.sh
>
> ... this is all a bit much for a single patch, I feel. Giving
> parse_tree_gently() a repo parameter, adding repo_parse_tree(), using
> it in read_tree_at(), adding a repo parameter to read_tree_fn_t,
> letting read_tree_at() recurse into submodules and adding the new
> option to git archive all seem like topics worth their own patch and
> rationale.
> You probably have all of that in your head right now, but at least my
> attention span and working memory capacity requires smaller morsels.
Does this mean I should create multiple PRs?
Or should they just be split up into individual commits.
I will work off assuming the latter.
I am comfortable rewriting history as long as I understand the direction to go in.
Should each individual patch be completely standalone?
(To the point where each set, with the previous patches should produce a working application?
Or is having the patch broken up by groups of changes, with some level of expecting the final
functionality good?)
But thanks so far. I will get working on this (and review your next set of messages).
next prev parent reply other threads:[~2022-10-13 21:38 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 17:52 [PATCH] archive: add --recurse-submodules to git-archive command Heather Lapointe via GitGitGadget
2022-10-13 11:35 ` [PATCH v2 0/2] archive: Add " Heather Lapointe via GitGitGadget
2022-10-13 11:35 ` [PATCH v2 1/2] archive: add " Alphadelta14 via GitGitGadget
2022-10-13 17:53 ` René Scharfe
2022-10-13 21:37 ` Heather Lapointe
2022-10-13 11:36 ` [PATCH v2 2/2] archive: fix a case of submodule in submodule traversal Alphadelta14 via GitGitGadget
2022-10-13 17:53 ` [PATCH v2 0/2] archive: Add --recurse-submodules to git-archive command René Scharfe
2022-10-13 21:23 ` Heather Lapointe [this message]
2022-10-14 9:47 ` René Scharfe
2022-10-17 2:23 ` [PATCH v3 0/9] " Heather Lapointe via GitGitGadget
2022-10-17 2:23 ` [PATCH v3 1/9] tree: do not use the_repository for tree traversal methods Alphadelta14 via GitGitGadget
2022-10-17 13:26 ` Junio C Hamano
2022-10-26 22:33 ` Glen Choo
2022-10-27 18:09 ` Jonathan Tan
2022-10-27 18:50 ` Junio C Hamano
2022-10-17 2:23 ` [PATCH v3 2/9] tree: update cases to use repo_ tree methods Heather Lapointe via GitGitGadget
2022-10-17 2:23 ` [PATCH v3 3/9] tree: increase test coverage for tree.c Heather Lapointe via GitGitGadget
2022-10-17 13:34 ` Phillip Wood
2022-10-17 13:36 ` Junio C Hamano
2022-10-27 18:28 ` Jonathan Tan
2022-10-17 2:23 ` [PATCH v3 4/9] tree: handle submodule case for read_tree_at properly Heather Lapointe via GitGitGadget
2022-10-17 13:48 ` Phillip Wood
2022-10-17 13:56 ` Junio C Hamano
2022-10-26 22:48 ` Glen Choo
2022-10-27 18:43 ` Jonathan Tan
2022-10-17 2:23 ` [PATCH v3 5/9] tree: add repository parameter to read_tree_fn_t Heather Lapointe via GitGitGadget
2022-10-17 2:23 ` [PATCH v3 6/9] archive: pass repo objects to write_archive handlers Heather Lapointe via GitGitGadget
2022-10-17 13:50 ` Phillip Wood
2022-10-17 2:23 ` [PATCH v3 7/9] archive: remove global repository from archive_args Heather Lapointe via GitGitGadget
2022-10-17 2:23 ` [PATCH v3 8/9] archive: add --recurse-submodules to git-archive command Heather Lapointe via GitGitGadget
2022-10-26 23:34 ` Glen Choo
2022-10-27 7:09 ` René Scharfe
2022-10-27 17:29 ` Glen Choo
2022-10-27 17:30 ` Glen Choo
2022-10-27 17:33 ` Glen Choo
2022-10-17 2:23 ` [PATCH v3 9/9] archive: add tests for git archive --recurse-submodules Heather Lapointe via GitGitGadget
2022-10-27 18:54 ` Jonathan Tan
2022-10-27 23:30 ` Glen Choo
2022-10-28 0:17 ` Ævar Arnfjörð Bjarmason
2022-10-17 13:57 ` [PATCH v3 0/9] archive: Add --recurse-submodules to git-archive command Phillip Wood
2022-10-18 18:34 ` Junio C Hamano
2022-10-18 18:48 ` Heather Lapointe
2022-10-19 16:16 ` Junio C Hamano
2022-10-19 20:44 ` Junio C Hamano
2022-10-20 1:21 ` Junio C Hamano
2022-10-21 1:43 ` Junio C Hamano
2022-10-26 22:14 ` Glen Choo
2022-10-28 18:18 ` Heather Lapointe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=183d33ad4dc.b3e5b5ca123845.2982022328880074553@alphaservcomputing.solutions \
--to=alpha@alphaservcomputing.solutions \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).