From: Victoria Dye <vdye@github.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "Jeff Hostetler" <git@jeffhostetler.com>,
"Jeff Hostetler via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Stefan Sundin" <git@stefansundin.com>,
"Bagas Sanjaya" <bagasdotme@gmail.com>,
"René Scharfe" <l.s.r@web.de>,
"Jeff Hostetler" <jeffhostetler@github.com>,
"Eric DeCosta" <edecosta@mathworks.com>
Subject: Re: [PATCH] fsmonitor: eliminate call to deprecated FSEventStream function
Date: Fri, 2 Dec 2022 13:17:49 -0800 [thread overview]
Message-ID: <1b090929-f2da-f075-01d4-458804fc0717@github.com> (raw)
In-Reply-To: <221202.86359xfs5c.gmgdl@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason wrote:
> Anyway, that larger topic aside. All I'm suggesting here is that the
> proposed patch seems to at least soft-deprecate versions of OSX we
> supported before. Maybe that's fine, but the commit message didn't get
> across whether that was considered, part of the plan etc.
...
> But git gets ported and backported to a long tail of systems way beyond
> that. Eventually we do need to let got, but we've generally drawn the
> line at some fuzzy notion of when users don't care anymore, along with
> whether it's worth the effort to find out.
My point is that such a user for this scenario is so unlikely to exist that
holding up this patch - which provides a real, tangible benefit to
developers *right now* - to implement your suggestion or modify the commit
message is, at best, an unnecessary distraction.
If, somewhere, there is a user that 1) keeps up-to-date with the latest
version of Git, 2) uses FSMonitor, and 3) is working on the sole version of
MacOS that was theoretically compatible with FSMonitor before this change
but now is not, we can accommodate that once such a need is shown to exist.
next prev parent reply other threads:[~2022-12-02 21:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 14:24 [PATCH] fsmonitor: eliminate call to deprecated FSEventStream function Jeff Hostetler via GitGitGadget
2022-12-02 17:42 ` Victoria Dye
2022-12-02 18:02 ` Ævar Arnfjörð Bjarmason
2022-12-02 18:37 ` Jeff Hostetler
2022-12-02 19:08 ` Ævar Arnfjörð Bjarmason
2022-12-02 19:51 ` Victoria Dye
2022-12-02 20:34 ` Ævar Arnfjörð Bjarmason
2022-12-02 21:17 ` Victoria Dye [this message]
2022-12-02 21:44 ` Stefan Sundin
2022-12-02 23:02 ` Ævar Arnfjörð Bjarmason
2022-12-03 1:05 ` Junio C Hamano
2022-12-05 0:58 ` Junio C Hamano
2022-12-05 14:34 ` Jeff Hostetler
2022-12-05 23:13 ` Junio C Hamano
2022-12-06 17:25 ` Jeff Hostetler
2022-12-14 19:12 ` [PATCH v2] " Jeff Hostetler via GitGitGadget
2022-12-15 0:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b090929-f2da-f075-01d4-458804fc0717@github.com \
--to=vdye@github.com \
--cc=avarab@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=edecosta@mathworks.com \
--cc=git@jeffhostetler.com \
--cc=git@stefansundin.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jeffhostetler@github.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).