From: Jonas Fonseca <fonseca@diku.dk>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: [PATCH] Fix cygwin install issues
Date: Mon, 10 Oct 2005 10:52:59 +0200 [thread overview]
Message-ID: <20051010085259.GA18009@diku.dk> (raw)
Support installing to paths including spaces.
Remove any old .exe files so ln will succeed.
Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
---
diff --git a/Makefile b/Makefile
index ac384c7..9ae0dfd 100644
--- a/Makefile
+++ b/Makefile
@@ -397,13 +397,13 @@ check:
### Installation rules
install: $(PROGRAMS) $(SCRIPTS)
- $(INSTALL) -d -m755 $(DESTDIR)$(bindir)
- $(INSTALL) $(PROGRAMS) $(SCRIPTS) $(DESTDIR)$(bindir)
- $(INSTALL) git-revert $(DESTDIR)$(bindir)/git-cherry-pick
- sh ./cmd-rename.sh $(DESTDIR)$(bindir)
+ $(INSTALL) -d -m755 "$(DESTDIR)$(bindir)"
+ $(INSTALL) $(PROGRAMS) $(SCRIPTS) "$(DESTDIR)$(bindir)"
+ $(INSTALL) git-revert "$(DESTDIR)$(bindir)/git-cherry-pick"
+ sh ./cmd-rename.sh "$(DESTDIR)$(bindir)" "$X"
$(MAKE) -C templates install
- $(INSTALL) -d -m755 $(DESTDIR)$(GIT_PYTHON_DIR)
- $(INSTALL) $(PYMODULES) $(DESTDIR)$(GIT_PYTHON_DIR)
+ $(INSTALL) -d -m755 "$(DESTDIR)$(GIT_PYTHON_DIR)"
+ $(INSTALL) $(PYMODULES) "$(DESTDIR)$(GIT_PYTHON_DIR)"
install-doc:
$(MAKE) -C Documentation install
diff --git a/cmd-rename.sh b/cmd-rename.sh
index 34e7f49..c9d3171 100755
--- a/cmd-rename.sh
+++ b/cmd-rename.sh
@@ -1,9 +1,10 @@
#!/bin/sh
d="$1"
+X="$2"
test -d "$d" || exit
while read old new
do
- rm -f "$d/$old"
+ rm -f "$d/$old" "$d/$old$X"
if test -f "$d/$new"
then
ln -s "$new" "$d/$old" || exit
--
Jonas Fonseca
next reply other threads:[~2005-10-10 8:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-10 8:52 Jonas Fonseca [this message]
2005-10-10 9:03 ` [PATCH] Fix cygwin install issues Jonas Fonseca
2005-10-10 9:09 ` Junio C Hamano
2005-10-10 9:26 ` [PATCH] git.sh: quote all paths Jonas Fonseca
2005-10-10 9:32 ` Jonas Fonseca
2005-10-10 15:02 ` [PATCH] Fix cygwin install issues H. Peter Anvin
2005-10-10 16:51 ` Junio C Hamano
2005-10-10 17:09 ` H. Peter Anvin
2005-10-10 20:52 ` Deal with $(bindir) and friends with whitespaces Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051010085259.GA18009@diku.dk \
--to=fonseca@diku.dk \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).