git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Charles Bailey <charles@hashpling.org>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC/PATCH] gitweb: Use list form of 'open "-|"' pipeline
Date: Sat, 8 Mar 2008 17:51:06 +0000	[thread overview]
Message-ID: <20080308175106.GA13855@hashpling.org> (raw)
In-Reply-To: <20080308165245.15343.62914.stgit@localhost.localdomain>

On Sat, Mar 08, 2008 at 05:57:20PM +0100, Jakub Narebski wrote:
> Add output_pipeline subroutine, which allows to use list form of
> pipeline; instead of
>   open my $fh, "-|", "cmd_1 option | cmd_2 argument"
> we can now write
>   my $fh = output_pipeline(['cmd_1', 'option'], ['cmd_2', 'argument']);
> which allows to avoid troubles with shell quoting, and avoid spawning
> shell.  Code is based on snippet http://www.perlmonks.org/?node_id=246397
> simplified a bit.
> 

I'm not a perl open expert, and I don't know if gitweb has other
issues on windows anyway, but the list time I experimented with it
neither the open( FHAND, "-|" ) trick, not the list form of open in
combination with the "-|" mode worked at all on windows.

Charles.

  reply	other threads:[~2008-03-08 17:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-08 16:57 [RFC/PATCH] gitweb: Use list form of 'open "-|"' pipeline Jakub Narebski
2008-03-08 17:51 ` Charles Bailey [this message]
2008-03-08 18:29   ` Jakub Narebski
2008-03-11  9:01 ` Frank Lichtenheld
2008-03-11 17:30   ` Jakub Narebski
2008-03-11 18:59     ` Frank Lichtenheld
2008-03-12  2:09       ` Jay Soffian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080308175106.GA13855@hashpling.org \
    --to=charles@hashpling.org \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).