From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: [PATCH 12/16] git-submodule: avoid sed input with no newline Date: Thu, 13 Mar 2008 08:46:14 -0400 Message-ID: <20080313124614.GE19485@coredump.intra.peff.net> References: <20080312214044.GM26286@coredump.intra.peff.net> <7vabl34lc0.fsf@gitster.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Whit Armstrong , git@vger.kernel.org To: Junio C Hamano X-From: git-owner@vger.kernel.org Thu Mar 13 13:47:09 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1JZmpk-0005Xc-ML for gcvg-git-2@gmane.org; Thu, 13 Mar 2008 13:46:57 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752664AbYCMMqR (ORCPT ); Thu, 13 Mar 2008 08:46:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752731AbYCMMqR (ORCPT ); Thu, 13 Mar 2008 08:46:17 -0400 Received: from 66-23-211-5.clients.speedfactory.net ([66.23.211.5]:3552 "EHLO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752417AbYCMMqR (ORCPT ); Thu, 13 Mar 2008 08:46:17 -0400 Received: (qmail 29139 invoked by uid 111); 13 Mar 2008 12:46:16 -0000 Received: from coredump.intra.peff.net (HELO coredump.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.32) with SMTP; Thu, 13 Mar 2008 08:46:16 -0400 Received: by coredump.intra.peff.net (sSMTP sendmail emulation); Thu, 13 Mar 2008 08:46:14 -0400 Content-Disposition: inline In-Reply-To: <7vabl34lc0.fsf@gitster.siamese.dyndns.org> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Wed, Mar 12, 2008 at 03:41:03PM -0700, Junio C Hamano wrote: > Good use of --literal. > > But doesn't this make you wonder if "--literal-match --get-regexp" is > quite a strange combination? "Literal" covers the value part but the key > is still regexp (and we do want it to behave that way). However, maybe we > would want to also allow "give entries whose key is this literal key and > whose value matches this regexp"? git config --get? The problem is that we are matching on two elements: key and value. The matching style of the key element is chosen by --get versus --get-regexp. However, the value_regex is selected implicitly by its presence, so there is no room to modify the flag in the same way. Perhaps --literal-value-match or just --literal-value would be a better name. -Peff