From: Jeff King <peff@peff.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
John Goerzen <jgoerzen@complete.org>
Subject: Re: [RFH] bug in unpack_trees
Date: Thu, 13 Mar 2008 10:00:05 -0400 [thread overview]
Message-ID: <20080313140005.GA30348@coredump.intra.peff.net> (raw)
In-Reply-To: <alpine.LFD.1.00.0803081417040.5896@woody.linux-foundation.org>
On Sat, Mar 08, 2008 at 02:25:03PM -0800, Linus Torvalds wrote:
> But when I just tested the bug-report case that Jeff described, it seems
> that I fixed the bug just with my cleanup. The current git "master" branch
> gives the following (incorrect) output for Jeff's script:
Heh. I never meant to just dump the bug on you and run away, but I
haven't had much of a chance to review your patches until now. Looks
like Junio shook all the bugs out, though. ;) Thanks for all the hard
work on this.
The _real_ bug which started this, though, was actually a git-rebase
problem reported by John Goerzen on a private repo. I'm 99% sure that
this read-tree issue was the problem, but it would be nice to confirm
it is fixed.
John, is it possible for you to re-try that rebase and confirm that it
works with the current master? I deleted the repo you sent me after
narrowing the bug.
-Peff
next prev parent reply other threads:[~2008-03-13 14:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 11:59 [RFH] bug in unpack_trees Jeff King
2008-03-04 21:31 ` Linus Torvalds
2008-03-05 6:47 ` Daniel Barkalow
2008-03-05 15:56 ` Linus Torvalds
2008-03-06 0:35 ` Linus Torvalds
2008-03-08 22:25 ` Linus Torvalds
2008-03-08 22:36 ` Daniel Barkalow
2008-03-13 14:00 ` Jeff King [this message]
2008-03-14 14:09 ` John Goerzen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080313140005.GA30348@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jgoerzen@complete.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).