git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Couder <chriscool@tuxfamily.org>
To: Xavier Maillard <xma@gnu.org>
Cc: junkio@cox.net, normalperson@yhbt.net, git@vger.kernel.org,
	jaysoffian@gmail.com
Subject: Re: [PATCH 1/2] web--browse: use custom commands defined at config time
Date: Tue, 18 Mar 2008 05:56:51 +0100	[thread overview]
Message-ID: <200803180556.51930.chriscool@tuxfamily.org> (raw)
In-Reply-To: <200803151300.m2FD0XWh003243@localhost.localdomain>

Le samedi 15 mars 2008, Xavier Maillard a écrit :
>    This patch adds a git config variable "browser.<tool>.cmd" which
>    allows a more flexible browser choice.
>
> Well done ! Now we need it in help.c too :)

I started by "man.<tool>.path" (patches should follow soon), and I will work 
on "man.<tool>.cmd" really soon now.

>    Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
>
> Tested-by: Xavier Maillard <xma@gnu.org>

Thanks again for your tests. They are very much appreciated.

> Please update the header file as well (copyright header, it is
> year 2008 here :)).

Is it so important ? Some files like "help.c" don't even have copyright 
notice. Isn't it ok as long as they come with the license file (COPYING) ?

Thanks,
Christian.

  reply	other threads:[~2008-03-18  4:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-14  4:56 [PATCH 1/2] web--browse: use custom commands defined at config time Christian Couder
2008-03-15 13:00 ` Xavier Maillard
2008-03-18  4:56   ` Christian Couder [this message]
2008-03-19  1:00     ` Xavier Maillard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803180556.51930.chriscool@tuxfamily.org \
    --to=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=jaysoffian@gmail.com \
    --cc=junkio@cox.net \
    --cc=normalperson@yhbt.net \
    --cc=xma@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).