From: Tommi Virtanen <tv@eagain.net>
To: git@vger.kernel.org
Cc: gitster@pobox.com
Subject: [PATCH] "git shell" won't work, need "git-shell"
Date: Sun, 24 Aug 2008 23:23:25 +0300 [thread overview]
Message-ID: <20080824202325.GA14930@eagain.net> (raw)
>From 8e7935231e8a91d470b3a4a2310803031ef49fc4 Mon Sep 17 00:00:00 2001
From: Tommi Virtanen <tv@eagain.net>
Date: Sun, 24 Aug 2008 23:20:33 +0300
Subject: [PATCH] Install git-shell in bindir, again.
/etc/passwd shell field must be something execable, you can't enter
"/usr/bin/git shell" there. git-shell must be present as a separate
executable, or it is useless.
Signed-off-by: Tommi Virtanen <tv@eagain.net>
---
Hi. Recent changes moved away from "git-foo" to "git foo", except for
some commands that needed backwards compatibility. However, git-shell
as a separate binary was removed. I hope you will reinstante git-shell
as a publicly visible binary in bin. Here's why:
The shell field in /etc/passwd is *exec*ed, not interpreted via sh -c
or some such. For example, source of Debian's shadow, containing
/bin/login:
libmisc/shell.c:80: execle (file, arg, (char *) 0, envp);
I also tested this for real, and having a
test:x:1001:1001:,,,:/home/test:/usr/bin/git-shell
line works, and
test:x:1001:1001:,,,:/home/test:/usr/bin/git shell
just makes ssh loop asking for a password, logging
"User test not allowed because shell /usr/bin/git shell does not exist"
So, as far as I understand, as it currently is, "git shell" is utterly
useless for what it was meant to do. Restoring "git-shell" will fix
it.
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 53ab4b5..24d5809 100644
--- a/Makefile
+++ b/Makefile
@@ -1351,7 +1351,7 @@ install: all
$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(bindir_SQ)'
$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(gitexec_instdir_SQ)'
$(INSTALL) $(ALL_PROGRAMS) '$(DESTDIR_SQ)$(gitexec_instdir_SQ)'
- $(INSTALL) git$X git-upload-pack$X git-receive-pack$X git-upload-archive$X '$(DESTDIR_SQ)$(bindir_SQ)'
+ $(INSTALL) git$X git-upload-pack$X git-receive-pack$X git-upload-archive$X git-shell$X '$(DESTDIR_SQ)$(bindir_SQ)'
$(MAKE) -C templates DESTDIR='$(DESTDIR_SQ)' install
$(MAKE) -C perl prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)' install
ifndef NO_TCLTK
--
1.6.0.2.g2ebc0.dirty
--
:(){ :|:&};:
next reply other threads:[~2008-08-24 20:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-24 20:23 Tommi Virtanen [this message]
2008-08-24 20:36 ` [PATCH] "git shell" won't work, need "git-shell" Junio C Hamano
2008-08-24 20:38 ` Tommi Virtanen
2008-08-24 21:20 ` Junio C Hamano
2008-08-24 22:25 ` Tommi Virtanen
2008-08-25 10:37 ` Johannes Schindelin
2008-08-25 11:44 ` Paolo Bonzini
2008-08-25 17:58 ` Johannes Schindelin
2008-08-25 18:25 ` Mikael Magnusson
2008-08-25 20:08 ` Johannes Schindelin
2008-08-25 20:28 ` Johannes Schindelin
2008-08-25 20:51 ` [PATCH 1/2] git wrapper: Make while loop more reader-friendly Johannes Schindelin
2008-08-25 20:52 ` [PATCH 2/2] git wrapper: execute git-shell when argv[1] is '-c' Johannes Schindelin
2008-08-25 21:03 ` Tommi Virtanen
2008-08-25 22:05 ` Johannes Schindelin
2008-08-25 22:20 ` Tommi Virtanen
2008-08-26 0:52 ` Johannes Schindelin
2008-08-26 6:53 ` Matthieu Moy
2008-08-26 17:43 ` Junio C Hamano
2008-08-26 8:50 ` [PATCH 1/2] git wrapper: Make while loop more reader-friendly Mike Ralphson
2008-08-25 17:08 ` [PATCH] "git shell" won't work, need "git-shell" Petr Baudis
2008-08-25 17:20 ` Dmitry Potapov
2008-08-25 17:26 ` Tommi Virtanen
2008-08-25 17:53 ` Dmitry Potapov
2008-08-25 18:17 ` Johannes Schindelin
2008-08-25 20:26 ` Dmitry Potapov
2008-08-25 20:40 ` Mike Hommey
2008-10-28 11:11 ` Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080824202325.GA14930@eagain.net \
--to=tv@eagain.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).