From: Stephan Beyer <s-beyer@gmx.net>
To: Jeff King <peff@peff.net>
Cc: David Symonds <dsymonds@gmail.com>,
git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Implement git-staged, an alias for 'git diff --cached'.
Date: Wed, 29 Oct 2008 02:01:07 +0100 [thread overview]
Message-ID: <20081029010107.GB12065@leksak.fem-net> (raw)
In-Reply-To: <20081029003931.GA7291@sigill.intra.peff.net>
Hi,
> > --- /dev/null
> > +++ b/git-staged.sh
> > @@ -0,0 +1,2 @@
> > +#!/bin/sh
> > +exec git diff --cached $*
>
> This is broken for arguments with spaces. Use "$@" instead.
>
> But I think this isn't a serious patch anyway, so we are probably
> wasting too much time on it. ;P
I'm still not understanding, what it's for.
Usability? Because doing
git config --global alias.staged 'diff --cached'
is lame?
Regards,
Stephan
PS: Btw, if ever meant serious, it's missing an insertion into
command-list.txt and serious documentation.
But I think you know that. :-)
--
Stephan Beyer <s-beyer@gmx.net>, PGP 0x6EDDD207FCC5040F
next prev parent reply other threads:[~2008-10-29 1:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 23:39 David Symonds
2008-10-28 23:46 ` Jeff King
2008-10-28 23:59 ` David Symonds
2008-10-29 0:39 ` Jeff King
2008-10-29 0:44 ` David Symonds
2008-10-29 1:02 ` Johannes Schindelin
2008-10-29 0:58 ` Jeff King
2008-10-29 10:59 ` Wincent Colaiuta
2008-10-29 15:08 ` Johannes Schindelin
2008-10-29 15:22 ` Stephan Beyer
2008-10-29 15:48 ` Johannes Schindelin
2008-10-29 16:16 ` Wincent Colaiuta
2008-10-29 17:03 ` Johannes Schindelin
2008-10-29 17:13 ` Pascal Obry
2008-10-29 17:42 ` Wincent Colaiuta
2008-10-29 18:30 ` Teemu Likonen
2008-10-29 20:24 ` David Kågedal
2008-10-29 19:23 ` Johannes Schindelin
2008-10-29 19:44 ` Wincent Colaiuta
2008-10-29 1:01 ` Stephan Beyer [this message]
2008-10-29 1:05 ` Jeff King
2008-10-29 14:33 ` Brandon Casey
2008-10-29 15:19 ` Jeff King
2008-10-29 14:58 ` Pascal Obry
2008-10-29 19:49 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081029010107.GB12065@leksak.fem-net \
--to=s-beyer@gmx.net \
--cc=dsymonds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--subject='Re: [PATCH] Implement git-staged, an alias for '\''git diff --cached'\''.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).