From: "Jan Krüger" <jk@jk.gs>
To: "Adeodato Simó" <dato@net.com.org.es>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Add a commit.signoff configuration variable to always use --signoff.
Date: Sat, 27 Dec 2008 20:15:41 +0100 [thread overview]
Message-ID: <20081227201541.4a352129@neuron> (raw)
In-Reply-To: <20081227184001.GA31893@chistera.yi.org>
Hi,
On Sat, 27 Dec 2008 19:40:01 +0100
"Adeodato Simó" <dato@net.com.org.es> wrote:
> > I think it might be a good idea to allow overriding the config
> > variable in the other direction, i.e. a --no-signoff option to
> > commit. [...]
>
> Good catch.
>
> --no-signoff exists already, so maybe git-rebase should just use it?
Oh, yeah, I didn't notice the option mechanism worked this way and the
options got parsed after processing the config variables. I guess
rebase and rebase--interactive should use it, then, and perhaps there
are other commands that should that I just don't know about (a grep
across all commands implemented in shell script didn't find anything
else, though).
-Jan
prev parent reply other threads:[~2008-12-27 19:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-26 12:56 [PATCH] Add a commit.signoff configuration variable to always use --signoff Adeodato Simó
2008-12-26 22:02 ` Nanako Shiraishi
2008-12-26 22:10 ` Adeodato Simó
2008-12-27 0:36 ` Junio C Hamano
2008-12-27 8:26 ` Adeodato Simó
2008-12-27 8:44 ` Junio C Hamano
2008-12-27 9:03 ` Adeodato Simó
2008-12-27 11:04 ` Thomas Rast
2008-12-27 11:05 ` Adeodato Simó
2008-12-27 11:53 ` Junio C Hamano
2008-12-27 12:01 ` Adeodato Simó
2008-12-29 11:16 ` [PATCH v3] Add a commit.signoff configuration option to always use --signoff in commit Adeodato Simó
2008-12-29 11:18 ` Adeodato Simó
2008-12-30 21:04 ` Junio C Hamano
2009-01-01 22:18 ` Adeodato Simó
2009-01-02 12:46 ` Adeodato Simó
2008-12-27 18:08 ` [PATCH] Add a commit.signoff configuration variable to always use --signoff Jan Krüger
2008-12-27 18:40 ` Adeodato Simó
2008-12-27 19:15 ` Jan Krüger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081227201541.4a352129@neuron \
--to=jk@jk.gs \
--cc=dato@net.com.org.es \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).