From: Heiko Voigt <hvoigt@hvoigt.net>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Add configuration variable for sign-off to format-patch
Date: Tue, 31 Mar 2009 22:43:48 +0200 [thread overview]
Message-ID: <20090331204338.GA88381@macbook.lan> (raw)
In-Reply-To: <20090331200457.GA23879@coredump.intra.peff.net>
On Tue, Mar 31, 2009 at 04:04:57PM -0400, Jeff King wrote:
> On Tue, Mar 31, 2009 at 08:50:19PM +0200, Heiko Voigt wrote:
>
> > If you regularly create patches which require a Signed-off: line you may
> > want to make it your default to add that line. It also helps you not to forget
> > to add the -s/--signoff switch.
>
> I personally have no problem with such an option, but it has been argued
> against before. E.g.:
>
> http://article.gmane.org/gmane.comp.version-control.git/32522
> http://article.gmane.org/gmane.comp.version-control.git/51780
>
> There is also some discussion here indicating that it might be accepted:
>
> http://article.gmane.org/gmane.comp.version-control.git/103939
I see, it is of course true that you should not just sign off
everything without thinking about it.
However I always read through my messages before sending them and it is
way easier to delete that line than typing/copying it.
I suppose if A changes a patch which originated from B he also needs to
be nice and delete that the sign-off line from B (at least initially).
I don't know but if I am preparing to send a patch and *see* my
signed-off line in the message I am conscious about it! I see this more
as another customization. Some people tend to forget to add the
signed-off and others might tend to forget to delete it. It should be on
you to find out what type you are.
cheers Heiko
next prev parent reply other threads:[~2009-03-31 20:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-31 18:50 [PATCH] Add configuration variable for sign-off to format-patch Heiko Voigt
2009-03-31 19:47 ` Andreas Ericsson
2009-04-01 17:53 ` Heiko Voigt
2009-03-31 20:04 ` Jeff King
2009-03-31 20:43 ` Heiko Voigt [this message]
2009-04-01 10:26 ` Jeff King
2009-04-01 17:51 ` [PATCH v2] " Heiko Voigt
2009-04-01 17:55 ` Sverre Rabbelier
2009-04-06 8:14 ` Junio C Hamano
2009-04-06 10:58 ` Andreas Ericsson
2009-04-06 11:36 ` Matthieu Moy
2009-04-06 18:09 ` Heiko Voigt
2009-04-07 7:23 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090331204338.GA88381@macbook.lan \
--to=hvoigt@hvoigt.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).