git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: Fredrik Skolmli <fredrik@frsk.net>,
	git@vger.kernel.org, Nicolas Sebrecht <nicolas.s.dev@gmx.fr>
Subject: Re: [PATCH] Documentation: Clarify which paths git-clean will affect
Date: Wed, 6 May 2009 15:24:47 +0200	[thread overview]
Message-ID: <200905061524.52186.trast@student.ethz.ch> (raw)
In-Reply-To: <7vk54v1py6.fsf@alter.siamese.dyndns.org>

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]

Junio C Hamano wrote:
> Thomas Rast <trast@student.ethz.ch> writes:
> 
> > -If any optional `<path>...` arguments are given, only those paths
> > -are affected.
> > +If any optional `<path>...` arguments are given, those paths are
> > +affected.  Otherwise, the cleaning starts at the current directory.
> 
> With or without path limiters, clean does not look outside the current
> directory; I think the "otherwise" makes things worse than the original.
> 
> I'd suggest not touching this paragraph at all, but instead say something
> like this at the beginning:
> 
> > -This allows cleaning the working tree by removing files that are not
> 
>     Cleans the working tree by recursively removing files that are not
>     under version control, starting from the current directory.

Indeed, yours is better.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2009-05-06 13:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-05  9:13 [PATCH] Documentation: Clarify which paths git-clean will affect Fredrik Skolmli
2009-05-05  9:55 ` Thomas Rast
2009-05-05 10:05   ` Fredrik Skolmli
2009-05-05 11:17     ` [PATCH] " Nicolas Sebrecht
2009-05-05 12:26     ` [PATCH] " Thomas Rast
2009-05-05 16:20       ` Junio C Hamano
2009-05-06 13:24         ` Thomas Rast [this message]
2009-05-06 16:31           ` Fredrik Skolmli
2009-05-06 17:57             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905061524.52186.trast@student.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=fredrik@frsk.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=nicolas.s.dev@gmx.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).