From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Shawn O. Pearce" Subject: Re: [PATCH 2/2] Use NullProgressMonitor.INSTANCE and indent for loop Date: Wed, 6 May 2009 13:41:25 -0700 Message-ID: <20090506204125.GJ30527@spearce.org> References: <1241642224-6914-1-git-send-email-alex.blewitt@gmail.com> <1241642224-6914-2-git-send-email-alex.blewitt@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: robin.rosenberg@dewire.com, git@vger.kernel.org To: Alex Blewitt X-From: git-owner@vger.kernel.org Wed May 06 22:43:16 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1M1nxT-0007xX-SZ for gcvg-git-2@gmane.org; Wed, 06 May 2009 22:43:16 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761435AbZEFUl0 (ORCPT ); Wed, 6 May 2009 16:41:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761437AbZEFUlZ (ORCPT ); Wed, 6 May 2009 16:41:25 -0400 Received: from george.spearce.org ([209.20.77.23]:51540 "EHLO george.spearce.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761438AbZEFUlZ (ORCPT ); Wed, 6 May 2009 16:41:25 -0400 Received: by george.spearce.org (Postfix, from userid 1001) id 6B37D381CE; Wed, 6 May 2009 20:41:25 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1241642224-6914-2-git-send-email-alex.blewitt@gmail.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Alex Blewitt wrote: > --- > .../src/org/spearce/jgit/lib/PackWriter.java | 25 ++++++++++--------- > 1 files changed, 13 insertions(+), 12 deletions(-) Huh. These two should have been squashed together; see "git rebase -i HEAD~2" and its "squash" subcommand. It looks fine otherwise. I'll squash here when I apply. Just keep it in mind for future reference. -- Shawn.